Skip to content

Conversation

@HemangChothani
Copy link
Contributor

Fixes #123

@HemangChothani HemangChothani requested a review from plamut July 16, 2020 11:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing colons the changes look good. Samples test failures are irrelevant, as the samples have not been migrated yet.

A new ``Dataset`` returned from the API.
Raises:
google.cloud.exceptions.Conflict
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colons are missing at the end of exception types.

@plamut plamut merged commit 9c3409b into googleapis:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: client.create_table raises Conflict instead of AlreadyExists

2 participants