Skip to content

feat: add util functions to get URLs for Vertex Tensorboard web app.#635

Merged
dizcology merged 1 commit intogoogleapis:masterfrom
karthikv2k:master
Aug 23, 2021
Merged

feat: add util functions to get URLs for Vertex Tensorboard web app.#635
dizcology merged 1 commit intogoogleapis:masterfrom
karthikv2k:master

Conversation

@karthikv2k
Copy link
Contributor

@karthikv2k karthikv2k commented Aug 17, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #644

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@karthikv2k karthikv2k changed the title Add util functions to get URLs for Tensorboard web app. feat: add util functions to get URLs for Vertex Tensorboard web app. Aug 19, 2021
@karthikv2k karthikv2k force-pushed the master branch 3 times, most recently from 0ea1bf6 to 5447114 Compare August 19, 2021 22:01
@karthikv2k karthikv2k marked this pull request as ready for review August 19, 2021 22:01
@karthikv2k karthikv2k requested a review from a team as a code owner August 19, 2021 22:01
@sasha-gitg sasha-gitg self-requested a review August 19, 2021 22:08
sasha-gitg
sasha-gitg approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Karthik!

google/cloud/aiplatform/utils/tensorboard_utils.py
)


def _parse_experiment_name(experiment_name: str) -> Dict[str, str]:
Copy link
Member

@sasha-gitg sasha-gitg Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reuse the parser in the gapic client: https://github.com/googleapis/python-aiplatform/blob/master/google/cloud/aiplatform_v1beta1/services/tensorboard_service/client.py#L209

Copy link
Member

@sasha-gitg sasha-gitg Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring

Copy link
Contributor Author

@karthikv2k karthikv2k Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Done.

@sasha-gitg sasha-gitg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2021
@karthikv2k karthikv2k force-pushed the master branch 5 times, most recently from 751dce5 to 05b36b9 Compare August 23, 2021 16:33
@dizcology dizcology merged commit 8d88c00 into googleapis:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcology dizcology dizcology approved these changes

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees

No one assigned

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add util functions to create URLs for viewing and comparing Vertex Tensorboard Experiments

4 participants

@karthikv2k @dizcology @sasha-gitg @yoshi-kokoro