feat: add filter and timestamp splits #627
Conversation
b7eac85 to
91d9c20
Compare
| training_fraction_split: float = 0.8, | ||
| validation_fraction_split: float = 0.1, | ||
| test_fraction_split: float = 0.1, | ||
| training_fraction_split: Optional[float] = None, |
There was a problem hiding this comment.
Moved default setting responsibility to server-side instead of in multiple places in the client.
6558de2 to
07b8843
Compare
| training_fraction_split=0.8, | ||
| validation_fraction_split=0.1, | ||
| test_fraction_split=0.1, | ||
| training_fraction_split=None, |
There was a problem hiding this comment.
Switch to None, hence deferring to server.
9b512fd to
4032b82
Compare
705e976 to
114560f
Compare
| model_tbt.display_name = model_display_name or self._display_name | ||
| model_tbt.labels = model_labels or self._labels | ||
|
|
||
| # AutoMLVideo does not support validation, so pass in '-' if any other filter split is provided. |
There was a problem hiding this comment.
This is a weird thing we have to do for AutoMLVideo, pending discussion with Video team.
| if not sync: | ||
| model_from_job.wait() | ||
|
|
||
| true_fraction_split = gca_training_pipeline.FractionSplit( |
There was a problem hiding this comment.
Removed since we test splits separately later.
sasha-gitg
left a comment
There was a problem hiding this comment.
Thanks Ivan! LGTM and left a few comments.
| of data will be used for training, 10% for validation, and 10% for test. | ||
|
|
||
| Data filter splits: | ||
| Assigns input data to training, validation, and test sets |
There was a problem hiding this comment.
| Assigns input data to training, validation, and test sets | |
| If using filter splits all of ``training_filter_split``, ``validation_filter_split`` and | |
| ``test_filter_split`` must be provided. | |
| Assigns input data to training, validation, and test sets |
Please apply this to class docstrings that support filter splits.
| Supported only for tabular Datasets. | ||
|
|
||
| Timestamp splits: | ||
| Assigns input data to training, validation, and test sets |
There was a problem hiding this comment.
| Assigns input data to training, validation, and test sets | |
| If using timestamp split please provide ```timestamp_split_column_name``` | |
| Any of ``training_fraction_split``, ``validation_fraction_split`` and | |
| ``test_fraction_split`` may optionally be provided. | |
| Assigns input data to training, validation, and test sets. |
Please apply this to class docstrings that support timestamp splits.
95b4229 to
c07d7fa
Compare
|
Will lint and merge. |
|
Merged without passing 'Sample Lint' check as I didn't modify sample code. |
Changes to training splits:
Future:
Continued from: #549