fix: re-encode public keys from google.jks into p12 format for android#1738
Merged
chingor13 merged 1 commit intogoogleapis:masterfrom Mar 10, 2021
Merged
fix: re-encode public keys from google.jks into p12 format for android#1738chingor13 merged 1 commit intogoogleapis:masterfrom
chingor13 merged 1 commit intogoogleapis:masterfrom
Conversation
elharo
reviewed
Mar 2, 2021
Contributor
elharo
left a comment
There was a problem hiding this comment.
did something change in google.p12? Githb shows this as empty?
Collaborator
Author
Perhaps the UI is confused as it's a binary file? When I run |
elharo
reviewed
Mar 2, 2021
Contributor
elharo
left a comment
There was a problem hiding this comment.
Kokoro fails on java 7, look related
Collaborator
Author
Yeah, it's strange because it passes on GitHub actions with Java 7 |
Member
|
I just submitted cl/360677807, which would prevent the "Kokoro - Test: Java 7". Feel free to revert cl/360677807 if you still need the Kokoro check. |
elharo
approved these changes
Mar 3, 2021
original-brownbear
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jul 7, 2021
In FIPS mode loading the `.p12` keystore used by the new SDK version is not supported because of "PBE AlgorithmParameters not available". Fortunately, the SDK still includes the old jks trust store so we can just manually load it the same way it was loaded by the previous version to fix things. Also, fixed `SocketAccess` to properly rethrow this kind of exception and not run into a class cast issue. Closes #75023 relates googleapis/google-api-java-client#1738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might fix #1570 - repackage our public keys in google.jks into google.p12.
Repackage command: