fix: socketfactory not registered for apache#1637
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Nov 16, 2020
arithmetic1728:master
Merged
fix: socketfactory not registered for apache#1637chingor13 merged 2 commits intogoogleapis:masterfrom arithmetic1728:master
chingor13 merged 2 commits intogoogleapis:masterfrom
arithmetic1728:master
Conversation
Contributor
Author
Refactored the code and added test. |
chingor13
approved these changes
Nov 16, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.31.1](https://www.github.com/googleapis/google-api-java-client/compare/v1.31.0...v1.31.1) (2020-11-16) ### Bug Fixes * socketfactory not registered for apache ([#1637](https://www.github.com/googleapis/google-api-java-client/issues/1637)) ([e886efa](https://www.github.com/googleapis/google-api-java-client/commit/e886efaa384bac106f2e5efcc3fb59901c251505)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
GoogleApacheHttpTransport,socketFactoryhas to be registered for https, and provided toconnectionManager. This PR does the following:httpandhttps, and pass to connection manager (reference).setSSLSocketFactory(socketFactory)from the chain of calls afterHttpClientBuilder.create(), since it will be overwritten by.setConnectionManager(connectionManager)