Skip to content

fix: user-agent should use identifier/version#1425

Merged
chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13:fix-user-agent
Nov 21, 2019
Merged

fix: user-agent should use identifier/version#1425
chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13:fix-user-agent

Conversation

@chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Nov 20, 2019

Fixes #1426

@chingor13 chingor13 requested a review from a team November 20, 2019 18:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2019
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this fix an open issue?

@chingor13 chingor13 merged commit bfb4d9c into googleapis:master Nov 21, 2019
@chingor13 chingor13 deleted the fix-user-agent branch November 21, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User-Agent string uses invalid format

4 participants