The issue originally was opened because the testbot doesn't return errors properly, see https://qa.drupal.org/pifr/test/632778 -- the error message is missing; the line number is the method not the actual assert. (#1 has a screenshot too.)
However, as msonnabaum refused to fix this it's clear that our PHPunit integration is unmaintained. We need someone who is willing to fix the technical issues at least, ideally the community issues as well (documentation, presentations, awareness etc. all missing).
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | Selection_140.png | 18.35 KB | chx |
Comments
Comment #1
chx commentedComment #2
msonnabaum commentedComment #4
chx commentedComment #4.0
chx commentedUpdated issue summary.
Comment #5
catchOpening an issue assigned to someone else is not on. Nor is changing the title/priority in this way.
Also the correct fix for this is for the test bot to directly run unit tests prior to simpletest and bail out if they fail (similar to the applies/lint checks now). Rather than running them circuitously via simpletest as it currently does.
Comment #6
chx commentedRemoving the simpletest integration completely is another way of fixing it for sure. First we patch bot then we remove that from core. Works for me.
Comment #7
chx commented> Opening an issue assigned to someone else is not on.
Erm, why not? I know two ways of getting attention of a maintainer, a) marking the issue major/critical b) assigned. So, why not?
Comment #8
catchWe could leave the simpletest integration in if we wanted to - just need an option to skip those tests from CLI / run them only from the UI or etc. Even running them twice for a while would not be a serious issue.
An issue needs to be assigned to a maintainer only if it requires feedback from them. Either 'no idea how to fix it', or 'two ways to fix it do you have a preference' or similar.
Having your name in MAINTAINERS.txt for a component != volunteering to fix every single bug in a component that comes up. Clearly #4 is using a different interpretation since there's nothing here that explicitly needs msonnabaum's input whatsoever.
Comment #8.0
catchUpdated issue summary.
Comment #17
quietone commentedThis looks like very much like a duplicate of #2769211: assertion messages and line numbers in PHPUnit tests are not reported by run-tests.sh or Simpletest UI which is now closed. The test bot does reports the error message and the line number of the failed assertion.
Closing this as a duplicate. As always, if this is incorrect please reopen and clarify what still needs to be done here.