Repository navigation
services: log an error to java logger when health-check disabled. - #5261
Merged
Merged
Conversation
ejona86
approved these changes
Jan 19, 2019
| if (Objects.equal(status.getCode(), Code.UNIMPLEMENTED)) { | ||
| disabled = true; | ||
| logger.log( | ||
| Level.SEVERE, "Health-check with {0} is disabled: {1}", |
Member
There was a problem hiding this comment.
Make it clear the status came from the server. For example, "Health-check with {0} is disabled. Server returned: {1}"
ejona86
approved these changes
Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by the spec:
https://github.com/grpc/proposal/blob/master/A17-client-side-health-checking.md