Conversation
Previous rules_nodejs entries on bazel-central-registry were created by hand. This moves our 'toolchain' example which is the natural e2e for bare rules_nodejs. We test it on BCR in the normal way. I'll need to make sure the Publish To BCR app is enabled for the bazelbuild/rules_nodejs repo.
kormide
reviewed
Apr 2, 2023
Collaborator
Author
|
I also now depend on aspect_bazel_lib copy_directory instead of the patched copy_file that we vendored from bazel-skylib, hopefully means we can drop that for 6.0 |
kormide
approved these changes
Apr 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous rules_nodejs entries on bazel-central-registry were created by hand. This moves our 'toolchain' example which is the natural e2e for bare rules_nodejs. We test it on BCR in the normal way.
I'll need to make sure the Publish To BCR app is enabled for the bazelbuild/rules_nodejs repo.