Activity for Mike Kupfer
-
Mike Kupfer modified ticket #473
mh-refile-msg vs mh-thread-refile
-
Make web site compatible with PHP 8
-
Update copyrights
-
Make compatible with PHP 7; use a staging area for htdocs
-
search should not create folder with all-numeric name
-
mh-complete-word is unused
-
The fix for this will be in Emacs 29.1 (commit b3de81a6ee3).
-
mhparam change in nmh 1.7
-
mh-complete-word is unused
-
Stefan Kangas has done some work here, e.g., removing mh-compat.el with 0a060a2bfe and b459e275c3, but it looks like there's still more to do.
-
provide better support for link checking (Emacs 29)
-
Raising the priority, as this is a new issue in Emacs 29 that we really ought to fix before Emacs 29 goes out the door.
-
mh-mime-save-parts prompt is broken
-
Fixed in Emacs 29.1 (2181495af8).
-
mh-kill-folder still uses mh-kill-folder-suppress-prompt-hooks
-
mh-execute-commands fails when default-directory no longer exists
-
Fixed in Emacs 29.1 (bb0af6489a).
-
mh-kill-folder still uses mh-kill-folder-suppress-prompt-hooks
-
mh-mime-save-parts prompt is broken
-
mh-mime-save-parts prompt is broken
-
The workaround for this bug is to kill the buffer *MH-E Log*
-
I checked for other instances in MH-E of this problem (default-directory getting munged by a cd) and didn't see any. I've got a preliminary patch for this issue that I'll try to get out for review next weekend. While I was testing, I noticed a problem with the prompt for mh-mime-save-parts. I've got a fix for that which I'll post for review at the same time.
-
mh-execute-commands fails when default-directory no longer exists
-
Yeah, I totally misread the docstring for "with-existing-directory", so forget that idea. Note that when saving attachments, it's a feature that the chosen directory is used the next time, so I'm not sure you'd want to switch directories back after the method. mh-mime-save-parts saves the chosen directory in mh-mime-save-parts-directory, which will get used to generate the prompt the next time. That part's fine. It's the cd into the target directory, which sets default-directory for the buffer and...
-
utf-8-encoded From field can clobber first part of subject in threaded mode
-
utf-8-encoded From field can clobber first part of subject in threaded mode
-
mh-execute-commands fails when default-directory no longer exists
-
I see that #'mh-mime-save-parts cd's into the directory, which would set default-directory, but it doesn't cd back after saving the MIME parts. I suspect it should use with-existing-directory, rather than cd.
-
Or maybe goto-address should leave text alone if it's already been propertized?
-
provide better support for link checking (Emacs 29)
-
The fontification of the suspicious link and the assignment of the mouse-over text to the warning emoji are done in #'shr-tag-a: (when url (shr-urlify (or shr-start start) (shr-expand-url url) title) ;; Check whether the URL is suspicious. (when-let ((warning (or (textsec-suspicious-p (shr-expand-url url) 'url) (textsec-suspicious-p (cons (shr-expand-url url) (buffer-substring (or shr-start start) (point))) 'link)))) (add-text-properties (or shr-start start) (point) (list 'face '(shr-link textsec-suspicious)))...
-
Here's a screenshot from Gnus, with the mouse over the warning emoji.
-
provide better support for link checking (Emacs 29)
-
The raw email is attached as email.eml.
-
utf-8-encoded From field can clobber first part of subject in threaded mode
-
Back in October (2021), there was a question on mh-e-users, asking why each invocation of "F n" in a folder was producing a new, numbered unseen sequence folder in +mhe-search, rather than just reusing +mhe-search/sequence/unseen. The problem wasn't readily reproducible, so we never got to root cause. I have now seen the problem a couple times. In each case, there is an Emacs backup file (and no other files) in the directory for +mhe-search/sequence/unseen.
-
Cannot forward message with double-line From
-
This was fixed by commit 2a4de5e5e5, which will appear in Emacs 28.1. Thanks to Lester Buck for the assist.
-
While we're at it, it seems like copying a message should remember/use the last target folder.
-
See also issue 495
-
broken URLs in user guide (X-Face)
-
message with "me" in cc: field don't get marked in scan listing
-
mh-funcall-if-exists ignores function if it wasn't there at compile time
-
improve handling of malformed HTML-only emails
-
improve handling of malformed HTML-only emails
-
mh-funcall-if-exists ignores function if it wasn't there at compile time
-
I still see it sometimes with Emacs 26.3, particularly when viewing PDF files with Evince. The problem seems to happen when the viewer writes something to stderr; the error message ends up in the show buffer.
-
move from cl to cl-lib
-
This was fixed by commit 74b097b61c5201405ad7bc5bb76f1ca0e794184b Author: Stefan Monnier monnier@iro.umontreal.ca Date: Tue Aug 6 03:56:51 2019 -0400 and will appear in Emacs 27.1.
-
broken URLs in user guide (X-Face)
-
Could this be related to #254?
-
See also #205
-
See also #486
-
mh-redistribute + identity is broken with nmh >= 1.5
-
This will be fixed in Emacs 27.1. commit e1646e1e2864d6eaf567f4fe77cc11d3e17dde51 Author: Mike Kupfer mkupfer@alum.berkeley.edu Date: Sat Aug 4 18:06:37 2018 -0700 Fix mh-redistribute to work with nmh 1.5 and identities (SF#268) Co-authored-by: Jeffrey C Honig <jch@honig.net> * lisp/mh-e/mh-comp.el (mh-redistribute): Add a non-optional identity parameter. Use mh-bare-components to generate a draft, then apply identity-specific settings. Add more details to the "Resent" annotation line. (mh-dist-formfile):...
-
mail composition broken with mailutils
-
Fixed by commit b73cde5e2815c531df7f5fd13e214a7d92f78239 Author: Mike Kupfer <mkupfer@alum.berkeley.edu> Date: Wed Jul 4 15:43:04 2018 -0700 Fix MH-E mail composition with GNU Mailutils (SF#485) * lisp/mh-e/mh-comp.el (mh-bare-components): Recursively delete the temporary folder. This will appear in Emacs 26.2.
-
I was able to "fix" the problem by disabling font-lock as part of the buffer reset that mh-display-msg does: (setq buffer-read-only nil) ;; Cleanup old mime handles (mh-mime-cleanup) (erase-buffer) ;; Changing contents, so this hook needs to be reinitialized. ;; pgp.el uses this. (if (boundp 'write-contents-hooks) ;Emacs 19 (kill-local-variable 'write-contents-hooks)) (font-lock-mode -1) And this does not break the fontification of the header or attributed text. But I can't tell whether this is a...
-
A little more experimentation shows that even if mh-highlight-citation-style is nil, MH-E ends up throwing away the fontification that shr did. Gnus doesn't seem to have these problems, so one possible way forward is to see how the MH-E message display code differs from the corresponding code in Gnus.
-
I was dinking around with this, and the problem is related to this block of code in mh-show-mode: (cond ((equal mh-highlight-citation-style 'font-lock) (setq font-lock-defaults '(mh-show-font-lock-keywords-with-cite t))) ((equal mh-highlight-citation-style 'gnus) (setq font-lock-defaults '((mh-show-font-lock-keywords) t nil nil nil (font-lock-fontify-region-function . mh-show-font-lock-fontify-region))) (mh-gnus-article-highlight-citation)) (t (setq font-lock-defaults '(mh-show-font-lock-keywords...
-
I was dinking around with this, and the problem is related to this block of code in mh-show-mode: (cond ((equal mh-highlight-citation-style 'font-lock) (setq font-lock-defaults '(mh-show-font-lock-keywords-with-cite t))) ((equal mh-highlight-citation-style 'gnus) (setq font-lock-defaults '((mh-show-font-lock-keywords) t nil nil nil (font-lock-fontify-region-function . mh-show-font-lock-fontify-region))) (mh-gnus-article-highlight-citation)) (t (setq font-lock-defaults '(mh-show-font-lock-keywords...
-
I was dinking around with this, and the problem is related to this block of code in mh-show-mode: (cond ((equal mh-highlight-citation-style 'font-lock) (setq font-lock-defaults '(mh-show-font-lock-keywords-with-cite t))) ((equal mh-highlight-citation-style 'gnus) (setq font-lock-defaults '((mh-show-font-lock-keywords) t nil nil nil (font-lock-fontify-region-function . mh-show-font-lock-fontify-region))) (mh-gnus-article-highlight-citation)) (t (setq font-lock-defaults '(mh-show-font-lock-keywords...
-
I was dinking around with this, and the problem is related to this block of code in mh-show-mode: (cond ((equal mh-highlight-citation-style 'font-lock) (setq font-lock-defaults '(mh-show-font-lock-keywords-with-cite t))) ((equal mh-highlight-citation-style 'gnus) (setq font-lock-defaults '((mh-show-font-lock-keywords) t nil nil nil (font-lock-fontify-region-function . mh-show-font-lock-fontify-region))) (mh-gnus-article-highlight-citation)) (t (setq font-lock-defaults '(mh-show-font-lock-keywords...
-
An alternative to using "comp -build" would be the patch described in https://sourceforge.net/p/mh-e/mailman/message/35302385/
-
MH-E should not whine if no MH is found when compiling Emacs
-
This was fixed with a series of changesets starting with commit 2dc909c67b987e20cbfd4816cb4264151c68f2f9 Author: Glenn Morris <rgm@gnu.org> Date: Wed Mar 7 22:56:23 2018 -0800 Suppress "No MH variant found" message (bug#30669) * lisp/mh-e/mh-e.el (mh-variant): Don't try to detect till needed. * lisp/mh-e/mh-e.el (mh-version, mh-variant-p): * lisp/mh-e/mh-comp.el (mh-insert-x-mailer): Ensure mh-variant-in-use is set. The fix will appear in Emacs 27.1.
-
mh-alias-system-aliases loses if nmh was installed from source
-
mhparam change in nmh 1.7
-
mhparam change in nmh 1.7
-
message/external-body is auto loaded
-
This was fixed in the context of bug #475.
-
This fix will be in Emacs 26.1: commit 1b082c886c9e2213a85b820c7f07cd5a30b8b99b Author: Mike Kupfer mkupfer@alum.berkeley.edu Date: Sat Nov 18 16:49:10 2017 -0800 MH-E: don't automatically download external-body parts * lisp/mh-e/mh-mime.el (mh-mime-display-single): Use mm-automatic-display-p to verify that a part should be displayed before doing the inline checks (SF#475).
-
Add ability to suppress message/external-body downloads
-
Add ability to suppress message/external-body downloads
-
This patch seems to work.
-
Sorry, I got confused. Gnus uses #'mm-automatic-external-display-p, but that's not relevant here. I should have referred to mm-automatic-display, which is a variable and does not include "message/external-body".
-
I tried out Greg's patch, and it does fix the problem. I'm nervous about removing "message/external-body" from mm-inlined-types, as there might be some subtle semantics about that variable that I don't understand. In particular, Gnus does not (AFAICT) try to download unless you tell Gnus that you want to see that part (e.g., by clicking on its button). I think a cleaner fix would involve #'mm-automatic-external-display-p. That's what Gnus appears to use.
-
I wonder if this could be a security vulnerability. Could this be used to overwrite the recipient's .ssh/authorized_keys, for example?
-
mh-alias-system-aliases loses if nmh was installed from source
-
It looks like this was fixed by commit 0992ec3b0bfaf98edce1d08462e9ec8e11d6b6e6 Author: Bill Wohler wohler@newt.com Date: Mon May 30 16:49:37 2016 -0700 Correct cl-flet usage (Bug#22317) * mh-compat.el: Rename mh-cl-flet to mh-flet and convert alias to macro using patch from Katsumi Yamaoka <yamaoka@jpl.org>. * mh-thread.el (mh-thread-set-tables): * mh-show.el (mh-gnus-article-highlight-citation): * mh-mime.el (mh-display-with-external-viewer): (mh-mime-display, mh-press-button, mh-push-button):...
-
Oops, I see that Glenn has already addressed this for 26.1 (git 1f8036a5).
-
revisit no-byte-compile for mh-gnus.el
-
Oops, I see that Glenn has already addressed this for 26.1 (git 1f8036a5).
-
wrap mh-require inside eval-and-compile?
-
revisit no-byte-compile for mh-gnus.el
-
wrap mh-require inside eval-and-compile?
-
In debbugs #25552, Glenn Morris noted that cl-lib is available from elpa.gnu.org...
-
move from cl to cl-lib
-
See also #482.
-
move from cl to cl-lib
-
Inconsistent behavior in replying to emails with UTF-8 (rfc2047) From fields
-
I have seen this issue, too, and Jeff's proposed fix makes the problem go away for...
-
The code to use "comp -build" is significantly cleaner than what's currently in mh-bare-components,...
-
mail composition broken with mailutils
-
I plan to address this at the same time as #485.
-
mail composition broken with mailutils
-
use "comp -build" with nmh 1.6?
-
It looks like mailutils 2.x also supports "comp -build", though I haven't tested...
-
MH-E should not whine if no MH is found when compiling Emacs
-
The message comes from the mh-variant-set call in the :set method for mh-variant...
1 >
