Menu ▾ ▴

#23 sispm_switch_on should check outlet state

v1.0 (example)
accepted
xypron
None
2
2018-11-18
2017-09-02
RichardEberhard
No

Hello,

the internal functions sispm_switch_on and sispm_switch_off should check the state of the outlet before sending the usb action.

If I call the "sispmctl -o 1" command frequently on an already active outlet it can happen that the relay(outlet) turns off(or fails?)

To prevent this and also to prevent unecessary usb commands, the code should check the state of the outlet before sending the command.

In addition to this it is more efficent to do the check in the program directly.

Checking the state in a third party application would require to start the program two times and two times parsing the output. Starting a program creates a lot of overhead.

So I would highly request such a check in your software.

Thank You

Discussion

  • RichardEberhard

    RichardEberhard - 2017-09-03

    I made a patch file.

     
    sispm_ctl.c

  • Pete Hildebrandt

    Pete Hildebrandt - 2017-09-03

    Thanks for the patch. I will have a look at it :)

     

  • xypron

    xypron - 2018-11-18
    • status: open --> accepted
    • assigned_to: xypron
     

Log in to post a comment.

MongoDB Logo MongoDB