Recent changes to 4845: (ok 4.4.3) White screen (Cloudflare)

#4845 (ok 4.4.3) White screen (Cloudflare)

Marc Delisle — Tue, 14 Apr 2015 17:33:01 -0000

summary: White screen (Cloudflare) --> (ok 4.4.3) White screen (Cloudflare)
status: open --> resolved
Group: 4.4.0 --> 4.4.2
Priority: Normal --> Low

#4845 White screen (Cloudflare)

Marc Delisle — Tue, 14 Apr 2015 17:32:39 -0000

Fix: https://github.com/phpmyadmin/phpmyadmin/commit/cfa542cfa9b8e9869c5a6c55d7db594261a93548

#4845 White screen (Cloudflare)

Staze — Tue, 14 Apr 2015 17:02:32 -0000

Ryan Stasel
staze@staze.org is probably the best bet.

#4845 White screen (Cloudflare)

Marc Delisle — Tue, 14 Apr 2015 17:01:32 -0000

Posting here is sufficient. May I have your full name and email?

#4845 White screen (Cloudflare)

Staze — Tue, 14 Apr 2015 17:00:32 -0000

I do, though I'm not sure how to actually formally agree? Do I email it somewhere, post it here, etc?

#4845 White screen (Cloudflare)

Marc Delisle — Tue, 14 Apr 2015 12:18:58 -0000

@Staze I agree to apply your patch and fix the unit tests. But do you agree to our DCO (https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO)?

Also we need your full name and email.

#4845 White screen (Cloudflare)

Marc Delisle — Tue, 14 Apr 2015 12:11:13 -0000

assigned_to: Marc Delisle

#4845 White screen (Cloudflare)

Staze — Mon, 13 Apr 2015 21:13:33 -0000

I'm not sure I see the harm in including it in base/core. I have asked if CF can address the issue with Rocketloader, but it seems like enough people use cloudflare, and the extra bytes to the code base seem reasonable to me.

#4845 White screen (Cloudflare)

Mon, 13 Apr 2015 20:44:51 -0000

I've opened a PR https://github.com/phpmyadmin/phpmyadmin/pull/1645 using the solution provided by @Staze.
The data-cfasync='true' is a custom HTML5 attribute used by CloudFlare which I suppose isn't the same for other providers, but is solves the problem. In case many users have this problem the PR could be merged otherwise I don't think that the problem should be solved by pMA.

#4845 White screen (Cloudflare)

Isaac Bennetch — Sun, 12 Apr 2015 02:27:47 -0000