Recent changes to bugs

Memory Leak in COPCGroup::readSync

Mferrel — Thu, 27 Feb 2014 19:25:27 -0000

This library appears to be inactive, but am submitting this so other users can correct code.

void COPCGroup::readSync(CAtlArray& items, COPCItem_DataMap & opcData, OPCDATASOURCE source){
OPCHANDLE serverHandles = buildServerHandleList(items);
HRESULT itemResult;
OPCITEMSTATE *itemState;
DWORD noItems = (DWORD)items.GetCount();

HRESULT result = iSychIO->Read(source, noItems, serverHandles, &itemState, &itemResult);
if (FAILED(result)){
    delete []serverHandles;
    throw OPCException("Read failed");
}

for (unsigned i = 0; i < noItems; i++){
    COPCItem * item = (COPCItem *)itemState[i].hClient;
    OPCItemData * data = CAsynchDataCallback::makeOPCDataItem(itemState[i].vDataValue, itemState[i].wQuality, itemState[i].ftTimeStamp, itemResult[i]);
    COPCItem_DataMap::CPair* pair = opcData.Lookup(item);
    if (pair == NULL){
        opcData.SetAt(item,data);
    } else {
        opcData.SetValueAt(pair,data);
    }
}

delete []serverHandles;
COPCClient::comFree(itemResult);
// added code
for(unsigned i = 0; i < noItems; ++i)
{
    VariantClear(&(itemState[i].vDataValue));
}
    // end added code
COPCClient::comFree(itemState);

}

Uninitialized member.

Anonymous — Mon, 12 Dec 2011 22:30:23 -0000

It seems there is an unitialized member, which causes the asynchronous reading to have a race condition that causes a crash.

Attached is a fix.

Memory Leak in COPCItem::getSupportedProperties()

Timmy McKinney — Tue, 02 Oct 2007 16:50:55 -0000

There appears to be a memory leak in COPCItem::getSupportedProperties(). It appears to be caused by the strings allocated for the item descriptions. When I add the following line of code in the FOR loop the leak disappears.

COPCClient::comFree(pDescriptions[i]);

Thanks for this OPC code. I am finding it very useful.

Best regards,
Timmy McKinney