mistake in CDavSocket.cpp

yuichi YONEKURA — Wed, 20 Apr 2005 08:11:00 -0000

There is a mistake in CDavSocket.cpp:337.

The CDavSocket::connectSSL() method is currently
written the following:

int nResult = SSL_connect(m_pSSL);
if(nResult != 1){
OI_DEBUG("Error connecting via SSL: %s\n",
ERR_reason_error_string(ERR_get_error()));
ERR_clear_error();
cleanupSSL();
cleanupSSLSession();

if(nResult = 0) { <--- Here(line 337)
/*handshake failed*/
return OIEEHANDSHAKEFAILED;
} else if(nResult < 0) {
/*fatal connection error*/
return OIEEFATALCONNERROR;
} else {
/*the impossible happened. openssl's problem*/
return OIEEGENERIC;
/*TODO: try to find where the problem is*/
OI_ASSERT(false);
}

If SSL_Connect() function fails, the method always
returns OIEEGENERIC. To corrent the behavior, It should
be modified the following:

if(nResult == 0) {

API

Steve Przepiora — Wed, 23 Feb 2005 16:03:05 -0000

The method:

void OnResourceFound(CDavResourceNode* pNode)

in CDavWorkSession is a little misleading. If you are
going to pass a pointer to a method it should be
'newed' and the called method should take
responsibility to delete it.

The code that calls it is:
CDavResourceNode theNode;
theNode.Parse(pNode);
OnResourceFound(&theNode);
break;

in daveworksession.cpp:440

A better way to define it if you don't want new a
CDavResourceNode would be:
void OnResourceFound(CDavResourceNode& pNode)

This is very explicit in saying this object will go
away so make a copy of it or forget about it.

The way it is currently defined means "here's a
pointer, its your take care of it yourself"

On a side note, since it is entirly plausible the
programmer will have to cache the CDavResourceNode
after its found a simple copy constructor would be
helpfull. This would allow you to pass in a reference
to the CDavResourceNode and allow the programmer to
create a new CDavResourceNode and store it locally.

This could be accomplished by DOMNode the
CDavResourceNode was created with to create another copy.

Recent changes to bugs

mistake in CDavSocket.cpp

API