Recent changes to bugs

Fix for -Werror=format-security issue

Tom 'spot' Callaway — Tue, 03 Dec 2013 17:00:10 -0000

Hello,

I'm currently the maintainer for iaxclient in Fedora. Recently, Fedora
began an effort to build all of our packages with the
-Werror=format-security compiler option.

For more details, please see:
https://bugzilla.redhat.com/show_bug.cgi?id=1037126

This required one minor patch for iaxclient (based on 2.1 beta3), please apply it for future releases. I waive all copyright applicable on the change, and where that is impossible, grant a license for you to use it under the same license
terms as the rest of iaxclient.

MD5: patch to fix GCC warning

Tristan Matthews — Wed, 10 Jul 2013 20:22:22 -0000

Currently GCC (4.8) reports the following warning for when compiling md5.c in libiax:
"dereferencing type-punned pointer will break strict-aliasing rules"

The attached patch resolves the issue by using a union in MD5Context for the "in" member, so it can be accessed as either a uint8_t[64] or a uint32_t[16].

MD5_Final not zeroing out struct properly

Tristan Matthews — Wed, 10 Jul 2013 19:27:55 -0000

Unless I'm mistaken, this line in md5.c:

memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */

is only zeroing the first few bytes of ctx, because sizeof is called on the pointer ctx instead of the struct to which it points. The attached patch resolves this issue.

building contrib/tcl fails due to not found iaxclient.h on

Sebastian Reitenbach — Wed, 16 Jun 2010 22:50:51 -0000

without appended patch i am unable to build contrib/tcl stuff on OpenBSD since it doesn't find the iaxclient.h header file.

building iaxcomm fails on OpenBSD

Sebastian Reitenbach — Wed, 16 Jun 2010 22:45:39 -0000

building iaxcomm on OpenBSD has several problems. appended patch fixes the problem for me.

compilation fails on px_unix_oss.c on OpenBSD

Sebastian Reitenbach — Wed, 16 Jun 2010 22:43:37 -0000

soundcard.h is not found on OpenBSD since it is search in the wrong place, appended patch fixes the problem for me.

compilation fails on lib/codec/ffmpeg.c on OpenBSD

Sebastian Reitenbach — Wed, 16 Jun 2010 22:42:10 -0000

compilation fails due to not found header file, avcodec.h is installed in libavcodec/avcodec.h, appended patch fixes the problem for me.

iaxclient fails to build on OpenBSD

Sebastian Reitenbach — Wed, 16 Jun 2010 22:40:22 -0000

compilation of iaxclient library fails on OpenBSD in lib/unixfuncs.c due to missing sched_get_priority_max and sched_get_priority_min.
Both values should be assumed to be 0 on OpenBSD.

Appended harsh patch fixes the problem for me, but its only useful to demonstrate the problem.

building tkphone on OpenBSD

Sebastian Reitenbach — Wed, 16 Jun 2010 22:37:01 -0000

the simpleclient/tkphone fails to build on OpenBSD because there are too many parameters to iaxc_initialize.

ans some lines below it was necessary to reshuffle some variable initialization to be able to build it on OpenBSD/sparc (because of gcc-2.95 compiler)

appended patch fixes both problems for me

test mode doesn't handle correctly audio

inode — Thu, 16 Apr 2009 12:55:11 -0000

During some test I see that if test mode is set the program doesn't open the connection correctly and no audio will be received. The callback IAXC_EVENT_AUDIO will not be set by the library. You can test it with the stresstest.c, you will see no audio frame will be received. If you disable the testmode you can receive the audio frames.

Tested on 2.1beta 3 and svn current (20090416)