Update www/otter-browser to Beta 5
ClosedPublic
Actions

Authored by alonso on Apr 24 2015, 11:08 AM.

Details

Reviewers

rakuco
makc

Summary

Pull in area51's otter changes which upate otter to it's april beta release. Also, the www/otter-browser port currently doesn't install most files that it puts into stagedir, which gets fixed by this commit.

Test Plan

Apply the attached patch on a current ports tree and rebuild otter-browser.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

alonso updated this revision to Diff 4978.Apr 24 2015, 11:08 AM

alonso retitled this revision from to Update www/otter-browser to Beta 5.

alonso updated this object.

alonso edited the test plan for this revision. (Show Details)

alonso added reviewers: rakuco, makc.

alonso set the repository for this revision to rP FreeBSD ports repository.

alonso added a subscriber: kde.

rakuco added inline comments.May 3 2015, 10:33 PM

files/patch-CMakeLists.txt
11	Any plans of upstreaming this?
pkg-plist
10	Shouldn't this end in `.gz`?

alonso added inline comments.May 4 2015, 7:35 AM

files/patch-CMakeLists.txt
11	Already tried doing so in September last year: https://github.com/OtterBrowser/otter-browser/issues/461
pkg-plist
10	Otter doesn't compress it. I could do so explicitly, but then it should probably also go to man/man1 instead of share/man/man1.

The compress-man target compresses all man pages automatically, so you shouldn't need to worry about this. Now I'm glad you mentioned the path thing, the man pages should be installed to /usr/local/man, not /usr/local/share/man.