Differential D19009

Disable LibVNC/libvncserver cmake default options
ClosedPublic
Actions

Authored by dereks_lifeofadishwasher.com on Jan 29 2019, 12:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 28, 3:10 AM

	Unknown Object (File)
	Tue, Jan 27, 11:03 PM

	Unknown Object (File)
	Tue, Jan 27, 4:37 PM

	Unknown Object (File)
	Tue, Jan 27, 3:07 PM

	Unknown Object (File)
	Tue, Jan 27, 3:06 PM

	Unknown Object (File)
	Tue, Jan 27, 4:45 AM

	Unknown Object (File)
	Fri, Jan 23, 11:04 AM

	Unknown Object (File)
	Jan 2 2026, 12:40 AM

Subscribers

None

Details

Reviewers

Commits

rP491673: - Add CMAKE options properly.

Summary

All cmake options default to YES so When building on a host system with
non-option or non-DEPENDS libs installed it's possible cmake will find
these and build parts of libvncserver that are not supported at this
time.

Disable all non-option and non-DEPENDS cmake options for now.
Enable cmake options that don't have ports options from USES= or that
can be found in the base system.

Test Plan

portlint, testport, bulk, test with virtualbox-ose

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereks_lifeofadishwasher.com created this revision.Jan 29 2019, 12:04 AM

Harbormaster completed remote builds in B22234: Diff 53350.Jan 29 2019, 12:04 AM

Based on comments from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234929
the last patch disabled some functionality with libvncserver. Also added SASL
support with patch to fix a build error.

Harbormaster completed remote builds in B22267: Diff 53413.Jan 30 2019, 5:03 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2019, 1:47 AM

Closed by commit rP491673: - Add CMAKE options properly. (authored by araujo). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

net/

libvncserver/

24 lines

files/

patch-libvncclient_sasl.c

11 lines

Diff 53452

head/net/libvncserver/Makefile

Loading...

head/net/libvncserver/files/patch-libvncclient_sasl.c

Loading...