bug: properly render the terminal when open() is called again #5253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Tyriar Hi, can you kindly approve the pipeline run so I could be sure if I need to make any further changes? Thanks! |
Tyriar
approved these changes
Jan 6, 2025
Member
Tyriar
left a comment
There was a problem hiding this comment.
No major concerns here, thanks!
Contributor
Author
|
@Tyriar Thanks for reviewing! Do we plan to cut a release anytime soon? |
8 tasks
Tyriar
added a commit
that referenced
this pull request
Feb 14, 2025
Revert "Merge pull request #5253 from akphi/patch-1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4978 based on the suggestion by @Tyriar in #4978 (comment)