chore: replace expect-legacy package with chai #184
Merged
+107
−1,254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
expect-legacywithchai.expect-legacyis an unmaintained fork ofexpect. It appears to be a fork becauseexpectjoined thejestproject. Given that the fork hasn't been updated in 8 years and has 99 sub-dependencies, it's a good time to migrate.chaiis good fit because it's often used withmochaalready and is a recommended package on the mocha docs. It keeps this update simple because moving everything tojestwould include migrating away frommocha. Sincemochaandchaiare both well maintained, this doesn't seem necessary at this point.The
toExistfunction inexpectis just checking for a truthy value, soto.be.okis the equivalent inchai. Similarly,toBeis replaced withto.equal.Please let me know if any changes are necessary. Thanks!