[4.x] Fix FileUpload not working inside collapsed Repeater#19139
Merged
danharrin merged 2 commits intofilamentphp:4.xfrom Jan 30, 2026
Merged
[4.x] Fix FileUpload not working inside collapsed Repeater#19139danharrin merged 2 commits intofilamentphp:4.xfrom
FileUpload not working inside collapsed Repeater#19139danharrin merged 2 commits intofilamentphp:4.xfrom
Conversation
FileUpload not working inside collapsed RepeaterFileUpload not working inside collapsed Repeater
danharrin
requested changes
Jan 30, 2026
| return | ||
| } | ||
|
|
||
| if (this.$el.offsetParent === null) { |
Member
There was a problem hiding this comment.
The only thing I can think of is maybe add this.visibilityObserver?.disconnect() again above here, so that if the component is initialised by Alpine at some point again when the observer is already registered, we don't have two instances active at once?
Apart from that, this looks like a great solution to the problem, thanks!
Member
|
Maybe it's worth checking if this fixes issue #15394 too, since its a bit of a similar problem? |
Contributor
Author
@danharrin Thanks for the heads up! Will check if this resolves #15394 as well. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #16253
FilePond calculates layout dimensions on init. When inside a collapsed Repeater (
display: none), all dimensions are 0, causing mispositioned elements and broken interactions.Fix: Defer initialization until the element becomes visible.
Visual changes
Before
before.mov
After
after.mov
Functional changes
composer cscommand.