Skip to content

feat: #18651 Ability to add ActionGroup to ->extraModalFooterActions()#18968

Merged
danharrin merged 18 commits intofilamentphp:5.xfrom
GeminiDev1:#18651-Ability-to-add-ActionGroup-to-extraModalFooterActions
Jan 22, 2026
Merged

feat: #18651 Ability to add ActionGroup to ->extraModalFooterActions()#18968
danharrin merged 18 commits intofilamentphp:5.xfrom
GeminiDev1:#18651-Ability-to-add-ActionGroup-to-extraModalFooterActions

Conversation

@GeminiDev1
Copy link
Contributor

Description

Resolves: #18651

Feature to add ActionGroup to extraModalFooterActions.

Visual changes

image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jan 14, 2026
@danharrin danharrin added the enhancement New feature or request label Jan 15, 2026
@danharrin danharrin added this to the v4 milestone Jan 15, 2026
@GeminiDev1 GeminiDev1 changed the base branch from 4.x to 5.x January 18, 2026 14:13
@GeminiDev1 GeminiDev1 changed the base branch from 5.x to 4.x January 20, 2026 12:29
@GeminiDev1 GeminiDev1 changed the base branch from 4.x to 5.x January 20, 2026 12:29
@danharrin danharrin merged commit ecf4dd5 into filamentphp:5.x Jan 22, 2026
23 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 22, 2026
danharrin added a commit that referenced this pull request Jan 22, 2026
#18968)

* feat: Added ability to add ActionGroup to extraModalFooterActions.

* tests: Implement multiple actions within ActionGroup for extraModalFooterActions

* test: Fixed ActionGroup test coverage for extraModalFooterActions()

Can't test locally, will rely on GitHub actions.

* test: Update ActionGroup test descriptions for clarity in extraModalFooterActions

* test: Simplify ActionGroup test by removing unnecessary assertions in extraModalFooterActions

* fix: Update the mountTableAction test to account for the recordKey in assertTableActionMounted

* refactor: Rename prepareActionGroup to prepareModalGroupAction for to match prepareModalAction naming.

* chore: fix code style

* cleanup

* Update CanOpenModal.php

* Update CanOpenModal.php

---------

Co-authored-by: GeminiDev1 <GeminiDev1@users.noreply.github.com>
Co-authored-by: Dan Harrin <git@danharrin.com>
@GeminiDev1 GeminiDev1 deleted the #18651-Ability-to-add-ActionGroup-to-extraModalFooterActions branch January 29, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants