Improve --migrate feature #678
Merged
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meteorcloudy
commented
Apr 9, 2025
- Test the original build without incompatible flags first.
- Return an unique exit code (73) when encountering incompatible flag only failures.
- Upgraded Bazel & some dependency
fweikert
approved these changes
Apr 9, 2025
1 task
meteorcloudy
added a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Apr 10, 2025
- Set `ENABLE_BAZELISK_MIGRATE` to `1` to enable this feature for BCR presubmit - Once enabled, the BCR presubmit will try to fetch incompatible flags from the `incompatible_flags.yml` file in the BCR root or `presubmit.yml` of the module. - Then the script set up env vars to enable bazelisk's [--migrate](https://github.com/bazelbuild/bazelisk?tab=readme-ov-file#--migrate) feature to test those incompatible flags. A Bazelisk improvement is needed at bazelbuild/bazelisk#678. - The incompatible flag tests can be skipped by applying `skip-incompatible-flags-test` flag to the BCR PR, which can be triggered by anyone with comment `@bazel-io skip_check incompatible_flags`. In the `incompatible_flags.yml` or `presubmit.yml` file, incompatible flags can be specified in the following format: ``` incompatible_flags: "--incompatible_config_setting_private_default_visibility": - 6.x - 7.x - 8.x "--incompatible_disable_native_repo_rules": - 7.x - 8.x "--incompatible_autoload_externally=": - 7.x - 8.x "--incompatible_disable_autoloads_in_main_repo": - last_green - rolling ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.