Fix F821 false negatives when from __future__ import annotations is active (attempt 2)
#10524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… active (attempt 2)
Contributor
|
charliermarsh
approved these changes
Mar 22, 2024
ngnpope
reviewed
May 2, 2024
| # More circular references | ||
| class Leaf: ... | ||
| class Tree(list[Tree | Leaf]): ... # Still invalid even when `__future__.annotations` are enabled | ||
| class Tree2(list["Tree | Leaf"]): ... # always okay |
Contributor
There was a problem hiding this comment.
This isn't quite testing what was intended and ought to be:
Suggested change
| class Tree2(list["Tree | Leaf"]): ... # always okay | |
| class Tree2(list["Tree2 | Leaf"]): ... # always okay |
Member
Author
There was a problem hiding this comment.
Good catch. Luckily the corrected test still passes, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt to fix #10340. The earlier attempt was #10362, which was reverted in #10513.
#10362 incorrectly only allowed forward references in annotations if we were in a "typing-only annotation". But forward references are allowed in all type annotations, not just typing-only annotations, iff
from __future__ import annotationsis at the top of the file.Test plan
cargo test. The tests added in #10513 should prevent a repeat of the earlier regression that #10362 caused.