Skip to content

Add proxy integration test#754

Merged
Link- merged 1 commit intomainfrom
Link-/add-proxy-integration-tests
Jan 30, 2026
Merged

Add proxy integration test#754
Link- merged 1 commit intomainfrom
Link-/add-proxy-integration-tests

Conversation

@Link-
Copy link
Member

@Link- Link- commented Jan 30, 2026

Proxy Integration Test for upload-artifact

This test validates that the upload-artifact action properly honors http_proxy and https_proxy environment variables.

How it works

  1. Environment Setup: Runs in an Ubuntu container with a Squid proxy service container
  2. Traffic Blocking: Uses iptables to block all direct HTTP/HTTPS traffic (ports 80/443), allowing only traffic through the proxy
  3. Verification: Confirms direct HTTPS requests fail while proxy requests succeed
  4. Test Execution: Uploads a timestamped test artifact file

Key point

If the action ignores the proxy configuration and attempts direct connections, the upload will fail due to iptables blocking. Success indicates the action correctly routes traffic through the configured proxy.

@Link- Link- requested a review from a team as a code owner January 30, 2026 10:30
Copilot AI review requested due to automatic review settings January 30, 2026 10:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a GitHub Actions workflow to validate that the upload-artifact action respects http_proxy and https_proxy environment variables by forcing all HTTP(S) traffic through a Squid proxy.

Changes:

  • Introduces .github/workflows/test-proxy.yml which runs a containerized Ubuntu job with a Squid proxy service.
  • Sets up iptables rules to block direct outbound HTTP/HTTPS (ports 80/443) while allowing traffic only to the proxy and DNS.
  • Verifies that direct HTTPS requests fail, HTTPS via the proxy succeeds, and then uploads a test artifact through the proxy using the local action (uses: ./).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Link- Link- merged commit 47309c9 into main Jan 30, 2026
16 checks passed
Pjrich1313

This comment was marked as off-topic.

@Link- Link- deleted the Link-/add-proxy-integration-tests branch February 5, 2026 12:11
fdio-github pushed a commit to FDio/csit that referenced this pull request Mar 2, 2026
Bumps actions/upload-artifact from 6 to 7.
## Release notes

Sourced from actions/upload-artifact's releases.

v7.0.0
v7 What's new
Direct Uploads
Adds support for uploading single files directly (unzipped). Callers can set the new archive parameter to false to skip zipping the file during upload. Right now, we only support single files. The action will fail if the glob passed resolves to multiple files. The name parameter is also ignored with this setting. Instead, the name of the artifact will be the name of the uploaded file.
ESM
To support new versions of the @actions/* packages, we've upgraded the package to ESM.
What's Changed

Add proxy integration test by @​Link- in actions/upload-artifact#754
Upgrade the module to ESM and bump dependencies by @​danwkennedy in actions/upload-artifact#762
Support direct file uploads by @​danwkennedy in actions/upload-artifact#764

New Contributors

@​Link- made their first contribution in actions/upload-artifact#754

Full Changelog: actions/upload-artifact@v6...v7.0.0

## Commits

bbbca2d Support direct file uploads (#764)
589182c Upgrade the module to ESM and bump dependencies (#762)
47309c9 Merge pull request #754 from actions/Link-/add-proxy-integration-tests
02a8460 Add proxy integration test
See full diff in compare view

![Dependabot compatibility score](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Signed-off-by: dependabot[bot] <support@github.com>
Change-Id: Ia2e29e951761b7cd74c86c9469ca502af2b566f6
GitHub-PR: #4131
GitHub-Hash: ec81e01b2a1da5f9
Signed-off-by: fdio.github <releng+fdio-github@linuxfoundation.org>
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Mar 3, 2026
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6.0.0 to 7.0.0.
Release notes

*Sourced from [actions/upload-artifact's releases](https://github.com/actions/upload-artifact/releases).*

> v7.0.0
> ------
>
> v7 What's new
> -------------
>
> ### Direct Uploads
>
> Adds support for uploading single files directly (unzipped). Callers can set the new `archive` parameter to `false` to skip zipping the file during upload. Right now, we only support single files. The action will fail if the glob passed resolves to multiple files. The `name` parameter is also ignored with this setting. Instead, the name of the artifact will be the name of the uploaded file.
>
> ### ESM
>
> To support new versions of the `@actions/*` packages, we've upgraded the package to ESM.
>
> What's Changed
> --------------
>
> * Add proxy integration test by [`@​Link`](https://github.com/Link)- in [actions/upload-artifact#754](https://redirect.github.com/actions/upload-artifact/pull/754)
> * Upgrade the module to ESM and bump dependencies by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#762](https://redirect.github.com/actions/upload-artifact/pull/762)
> * Support direct file uploads by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#764](https://redirect.github.com/actions/upload-artifact/pull/764)
>
> New Contributors
> ----------------
>
> * [`@​Link`](https://github.com/Link)- made their first contribution in [actions/upload-artifact#754](https://redirect.github.com/actions/upload-artifact/pull/754)
>
> **Full Changelog**: <actions/upload-artifact@v6...v7.0.0>


Commits

* [`bbbca2d`](actions/upload-artifact@bbbca2d) Support direct file uploads ([#764](https://redirect.github.com/actions/upload-artifact/issues/764))
* [`589182c`](actions/upload-artifact@589182c) Upgrade the module to ESM and bump dependencies ([#762](https://redirect.github.com/actions/upload-artifact/issues/762))
* [`47309c9`](actions/upload-artifact@47309c9) Merge pull request [#754](https://redirect.github.com/actions/upload-artifact/issues/754) from actions/Link-/add-proxy-integration-tests
* [`02a8460`](actions/upload-artifact@02a8460) Add proxy integration test
* See full diff in [compare view](actions/upload-artifact@b7c566a...bbbca2d)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/upload-artifact&package-manager=github\_actions&previous-version=6.0.0&new-version=7.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants