This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Feature/log writer mail factory#7294
Merged
weierophinney merged 4 commits intozendframework:developfrom Mar 10, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
This should probably be fed via a dataProvider to ensure other types raise the exception; I can add that during merge.
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
Feature/log writer mail factory
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
- Added data provider to test case - Renamed test case to better describe behavior being tested - Extracted setter name creation to a method for readability
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…e/log-writer-mail-factory Feature/log writer mail factory
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
- Added data provider to test case - Renamed test case to better describe behavior being tested - Extracted setter name creation to a method for readability
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…e/log-writer-mail-factory Feature/log writer mail factory
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new PR for #6619