This repository was archived by the owner on Jan 8, 2020. It is now read-only.
DI definition list optimisation - Cache classes upfront where possible to reduce iterations#6747
Merged
weierophinney merged 1 commit intozendframework:developfrom Feb 23, 2015
Conversation
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
DI definition list optimisation - Cache classes upfront where possible to reduce iterations
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
- space around operators and between parens/opening braces - use strict comparison when checking return value of assignment in a conditional
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
Member
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…DI-DefinitionList-Optimisation DI definition list optimisation - Cache classes upfront where possible to reduce iterations
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…DI-DefinitionList-Optimisation DI definition list optimisation - Cache classes upfront where possible to reduce iterations
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
- space around operators and between parens/opening braces - use strict comparison when checking return value of assignment in a conditional
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition lists are currently expensive with multiple definitions as they iterate over all of the definitions, often multiple times. The attached changes store which classes a definition knows about up front and looks them up via an array key in, iirc, constant time.
In some cases it may be possible that the lookup from the array isn't complete, e.g. in the case of getting a
PartialMarker, in which case it falls back to iterating. It also takes into account the possibility of classes existing inRuntimeDefinitions which won't know upfront which classes it can handle.This has made a significant impact to time spent in Di for our requests.