Added password prompt to Console

[richardjh]

SImple prompt that doesn't echo back (or can echo *s). Useful for reading in passwords.
If accepted I'll write up the documentation too.

[eddiejaoude]

I don't think this $this->password = '' is required as it is a duplicate from line 27

[richardjh]

Agreed, I'll pull it.

[eddiejaoude]

Nice one. 👍

[eddiejaoude]

I would type case this $this->promptText = (string) $promptText;

[samsonasik]

unneeded blank line

[eddiejaoude]

The tests seem to pass, but the build gets terminated...No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

End of output...

...............................................................  63 / 151 ( 41%)
.........S..S....................................SSSSSS........ 126 / 151 ( 83%)
...................SSSSSS
Time: 1.69 seconds, Memory: 12.25Mb
OK, but incomplete or skipped tests!
Tests: 151, Assertions: 333, Skipped: 14.
Generating code coverage report in PHP format ... done
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

[eddiejaoude]

I was not able to request Travis to rebuild this branch.

I looked at previous commits in this branch and they fail on Travis for the same reason. Tests seem to pass fine, the build gets terminated.

@richardjh Is it worth merging master in again?

[eddiejaoude]

I just checked master build and it is failing for the same reason!

[richardjh]

@eddiejaoude, are you saying I need to pull the master branch from zendframework/zf2 into my master branch on richardjh/zf2 again?

[eddiejaoude]

Originally, I was suggesting updating your PR branch (richardjh/zf2:master) with the master of zendframework/zf2:master - but when I checked the source branch (zendframework/zf2:master), it is failing too.

So probably no need, unless there is a manual conflict to resolve before your PR gets merged in - as they are new files, it is unlikely there will be a future conflict.

[asgrim]

Just a little suggestion, what about making the "mask" character configurable? (e.g. if someone wanted to use # instead of * to mask the password)

[eddiejaoude]

@asgrim good idea 👍

[prolic]

Should be 'Password: ' not 'Password : '

[richardjh]

Not sure if anyone is waiting for this or needs a password prompt, but I have added richardjh\zf2-password to packagist [ https://packagist.org/packages/richardjh/zf2-password ] so you can install the password prompt as a module if you like.

[eddiejaoude]

Thanks @richardjh 👍

[prolic]

nice

[samsonasik]

2015 ;)

[Ocramius]

This was merged into develop at 306c17a

I had to rewrite some bits because the prompt was actually acting really weird when entering multiple rapidly subsequent chars: figured that (for security) the best solution was to clear the line at every keystroke instead.