Reduced code duplication in FlashMessenger plugin

[fp-pszczekutowicz]

• Zend/Mvc/Controller/Plugin/FlashMessenger.php

[Ocramius]

All these new $namespace parameters need related tests

[fp-pszczekutowicz]

Tests created

[Ocramius]

Marking as bc-break since you added parameters to the methods.

[weierophinney]

@Ocramius not necessarily a BC break, as the new parameters are optional; original behavior is preserved, and you can call them without the arguments.

[Ocramius]

@weierophinney subclasses would still need change

[weierophinney]

@Ocramius good point.

@pszczekutowicz You can make this BC safe by removing the default argument, and instead using func_num_args and func_get_arg in your methods. It's more code, but simplifies the story for those subclassing the plugin.

[Ocramius]

@weierophinney the BC break is acceptable if we schedule this for 2.4 (imo)

[fp-pszczekutowicz]

Any conclusion @Ocramius @weierophinney? Should i commit the change?

[weierophinney]

@pszczekutowicz I believe @Ocramius is saying he can merge it as-is to develop for release with 2.4.0.

[ThaDafinser]

@pszczekutowicz thanks for the change
@Ocramius thank you for merging it not before 2.4.0 -> i exactly run into the BC break with subclasses