Skip to content

Commit f7e5fa7

Browse files
committed
AtomicBoolean shouldn't be volatile
The isClosed reference is always to the same instance of AtomicBoolean, hence it should be final rather than volatile.
1 parent 2b8ecd6 commit f7e5fa7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/org/java_websocket/server/WebSocketServer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,14 @@ public abstract class WebSocketServer extends WebSocketAdapter implements Runnab
7777

7878
private Thread selectorthread;
7979

80-
private volatile AtomicBoolean isclosed = new AtomicBoolean( false );
80+
private final AtomicBoolean isclosed = new AtomicBoolean( false );
8181

8282
private List<WebSocketWorker> decoders;
8383

8484
private List<WebSocketImpl> iqueue;
8585
private BlockingQueue<ByteBuffer> buffers;
8686
private int queueinvokes = 0;
87-
private AtomicInteger queuesize = new AtomicInteger( 0 );
87+
private final AtomicInteger queuesize = new AtomicInteger( 0 );
8888

8989
private WebSocketServerFactory wsf = new DefaultWebSocketServerFactory();
9090

0 commit comments

Comments
 (0)