Issue 554 (cztomczak#557)

* Do not link against libpython on Linux (cztomczak#554).

* Part 2. Do not link against libpython library on Linux (cztomczak#554).

Author: cztomczak

tools/build.py

@@ -238,7 +238,7 @@ def check_directories():
         prebuilt_name = get_cef_binaries_libraries_basename(OS_POSTFIX2)
         print("[build.py] ERROR: Couldn't find CEF prebuilt binaries and"
               " libraries: 'build/{prebuilt_dir}/'. Download it"
-              " from GitHub released tagged eg. 'v50-upstream` or download"
+              " from GitHub released tagged eg. 'vXX-upstream` or download"
               " CEF binaries from Spotify Automated Builds and then run"
               "`automate.py --prebuilt-cef`."
               .format(prebuilt_dir=prebuilt_name))

tools/cython_setup.py

@@ -25,6 +25,7 @@
 import sys
 import platform
 import Cython
+import copy
 import os
 
 # Must monkey patch Cython's ModuleNode to inject custom C++ code
@@ -65,6 +66,27 @@ def generate_extern_c_macro_definition(self, code):
             generate_extern_c_macro_definition)
 
 
+# Issue #554: Shared libraries in manylinux1 wheel should not
+#             be linked against libpythonX.Y.so.1.0.
+if LINUX:
+    get_libraries_old = (build_ext.get_libraries)
+    def get_libraries_new(self, ext):
+        libraries = get_libraries_old(self, ext)
+        libpython = ('python' + str(sys.version_info.major) + '.'
+                     + str(sys.version_info.minor))
+        for lib in copy.copy(libraries):
+            # Library name for Python versions before 3.8 may have
+            # an 'm' at the end.
+            if lib.startswith(libpython):
+                print("[cython_setup.py] Do not link against -l%s (Issue #554)"
+                    % lib)
+                libraries.remove(lib)
+        return libraries
+    build_ext.get_libraries = (
+            get_libraries_new
+    )
+
+
 # Command line args
 FAST_FLAG = False
 ENABLE_PROFILING = False