Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/python-fire
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: xosnos/python-fire
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 24, 2021

  1. Fix issue #309

    @xosnos
    xosnos committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    9496fc7 View commit details
    Browse the repository at this point in the history

  2. Extend fix for issue #309

    @xosnos
    xosnos committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6ad659e View commit details
    Browse the repository at this point in the history

  3. Fix style

    @xosnos
    xosnos committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    64d4a1a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Make changes based on suggestions from @MichaelCG8 

    - Update comments in _consume_google_args_line to match new logic
- Fix indentation logic: indent_check compares current line indent with first line indent for argument.
- Add new function _is_arg_type to check if arg type is of valid form
- Fix tests for multiline helptexts with colons and indents
    @xosnos
    xosnos committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    434fffa View commit details
    Browse the repository at this point in the history
Loading