Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance]: V0.6.0 version of the model, benchmarking found that the number of successful responses accounted for half of the number of requests, which is why #8349

Closed
1 task done
Amber-Believe opened this issue Sep 11, 2024 · 9 comments
Labels
performance Performance-related issues stale

Comments

@Amber-Believe
Copy link

Proposal to improve performance

No response

Report of performance regression

No response

Misc discussion on performance

No response

Your current environment (if you think it is necessary)

The output of `python collect_env.py`

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@Amber-Believe Amber-Believe added the performance Performance-related issues label Sep 11, 2024
@Amber-Believe
Copy link
Author

企业微信截图_17259622432984
In the v0.6.0 model, the total number of requests is 1000, -- the request-rate is 100, 1) only half of the requests are successfully responded to, why do so many fail? At the same time, check the output length, found that the output length is only 502 non-empty replies, 2) That is to say, the successful response is also None, what is the reason.

@youkaichao
Copy link
Member

cc @KuntaiDu

@youkaichao
Copy link
Member

@Amber-Believe make sure you follow #8176

@Amber-Believe
Copy link
Author

@Amber-Believe确保你关注了#8176

Hello, so the meaning here is that the number of successful responses is only half due to the problem of the multi-step scheduler (--num-scheduler-steps 10)?

@KuntaiDu
Copy link
Collaborator

IIRC vLLM's request buffer size is not large enough to hold 1000 requests. Try use 500 requests instead.

@KuntaiDu
Copy link
Collaborator

And also would be great if you could use latest vLLM version, there are several stabiliy-related bug fixes there.

@Amber-Believe
Copy link
Author

Okay, I'll try the new version of vllm

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Dec 20, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related issues stale
Projects
None yet
Development

No branches or pull requests

3 participants