Error not reported for list<key-of<properties-of<self>>>

[zmitic]

Based on documentation, the following code should report problems for attributeNames method but it doesn't: https://psalm.dev/r/bbd2bcc7b2

Use-case: this type is perfect for Doctrine PreUpdate event when we need to do something, but only when specified properties are updated and not all.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/bbd2bcc7b2

<?php

class A 
{
  public string $foo = 'foo!';
  public int $bar = 42;

  /**
   * @return list<key-of<properties-of<self>>>
   */
  public function attributeNames(): array 
  {
    return ['not_existing_property_1', 'not_existing_property_2'];
  }
}

$a = new A();
$b = $a->attributeNames();
/** @psalm-trace $b */

Psalm output (using commit c105211):

INFO: Trace - 19:23 - $b: list<string>

[danog]

The class is non-final, making it final fixes the issue (though since here we're explicitly specifying self, that should not be an issue...)

[zmitic]

Thanks, this helped a lot. I can't make the class final because of Doctrine, but I can make phpdoc version of it and now it works: https://psalm.dev/r/91ef7f5c23

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/91ef7f5c23

<?php

/** @final */
class A 
{
  public string $foo = 'foo!';
  public int $bar = 42;

  /**
   * @return list<key-of<properties-of<self>>>
   */
  public function attributeNames(): array 
  {
    return ['not_existing_property_1', 'not_existing_property_2'];
  }
}

$a = new A();
$b = $a->attributeNames();
/** @psalm-trace $b */

Psalm output (using commit d161a53):

INFO: Trace - 20:23 - $b: list<'bar'|'foo'>

ERROR: InvalidReturnStatement - 14:12 - The inferred type 'list{'not_existing_property_1', 'not_existing_property_2'}' does not match the declared return type 'list<'bar'|'foo'>' for A::attributeNames

ERROR: InvalidReturnType - 10:14 - The declared return type 'list<'bar'|'foo'>' for A::attributeNames is incorrect, got 'list{'not_existing_property_1', 'not_existing_property_2'}'