Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: validator/htmlparser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: validator/htmlparser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-1.5
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 11 files changed
  • 5 contributors

Commits on Jul 4, 2020

  1. Conform ampersand-error reporting to HTML spec

    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    a2c5bbf View commit details
    Browse the repository at this point in the history

  2. Fix grammar problem in HTML parser error message

    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    2b06e4d View commit details
    Browse the repository at this point in the history

  3. Fix "non-space characters insided a table" typo

    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    8bd0b78 View commit details
    Browse the repository at this point in the history

  4. Report 1024 as byte limit for meta charset sniff 

    Fixes validator/validator#232
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    8fac68b View commit details
    Browse the repository at this point in the history

  5. Make consecutive hyphens in comments a non-error 

    Also allow `<!-->` at (IE conditional) comment end

See whatwg/html#1356
See whatwg/html#1456
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    20eaf92 View commit details
    Browse the repository at this point in the history

  6. Correct error for EOF in “in template” state 

    Doing `errUnclosedElements(eltPos, "template")` for EOF in the “in
template” state results in the error message “End tag `template` seen, but
there were open elements”, which is all wrong because the actual problem is
that though a `template` end tag was expected, EOF was reached without a
`template` end tag being seen.

So let’s instead when we reach this just report the list of open elements.
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    82d4913 View commit details
    Browse the repository at this point in the history

  7. Report error always for Transitional doctype 

    Fixes validator/validator#408 Thanks @still-dreaming-1
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    4a37fe9 View commit details
    Browse the repository at this point in the history

  8. Remove warning about comments before doctype 

    This only applied to IE6..9, and does not apply to conditional comments.
    @zcorpan @sideshowbarker
    zcorpan authored and sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    303dcc8 View commit details
    Browse the repository at this point in the history

  9. Support “generate all implied end tags thoroughly” 

    When the parser encounters a `</template>` end tag and there are other
open elements, the HTML spec requires the parser to “generate all
implied end tags thoroughly”, which unlike “generate implied end tags”
also includes generating implied end tags for table-parts elements
(caption, colgroup, tbody, thead, tfoot, td, th, and tr).
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    751b678 View commit details
    Browse the repository at this point in the history

  10. Drop parse error for missing </caption> end tag 

    See https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-incaption:stack-of-open-elements-2
The parse error for this case was dropped from the spec in
whatwg/html@759ee62

Relates to validator/validator#593
and https://bugzilla.mozilla.org/show_bug.cgi?id=1429415
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    77503d9 View commit details
    Browse the repository at this point in the history

  11. Require UTF-8 

    See https://html.spec.whatwg.org/multipage/semantics.html#charset:utf-8
and whatwg/html@fae77e3
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    4a68e5c View commit details
    Browse the repository at this point in the history

  12. Add suppress "unchecked" for a TreeBuilder method 

    In `nu.validator.htmlparser.impl.TreeBuilder`, this change adds
`@SuppressWarnings("unchecked")` to the `getUnusedStackNode()` method.
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    8433716 View commit details
    Browse the repository at this point in the history

  13. Fix typo in error message about over-deep tree

    @mattbrundage @sideshowbarker
    mattbrundage authored and sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    f475aa6 View commit details
    Browse the repository at this point in the history

  14. Improve message: bad start tag in noscript in head

    @zcorpan @sideshowbarker
    zcorpan authored and sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    291b51e View commit details
    Browse the repository at this point in the history

  15. Ensure every Locator is also a Locator2 (#10) 

    * Replace org.xml.sax.helpers.LocatorImpl with nu.validator.htmlparser.impl.LocatorImpl

* instanceof before cast to Locator2
    @faceless2 @sideshowbarker
    faceless2 authored and sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    c4935b1 View commit details
    Browse the repository at this point in the history

  16. Mozilla bug 1650066 fixup - Avoid calling errListUnclosedStartTags in… 

    … C++.

Differential Revision: https://phabricator.services.mozilla.com/D82007
    @hsivonen @sideshowbarker
    hsivonen authored and sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    9e15251 View commit details
    Browse the repository at this point in the history

  17. Stay in the COMMENT_LESSTHAN state, annotate fall-throughs.

    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    c7a2fce View commit details
    Browse the repository at this point in the history

  18. Limit ambiguous-ampersand wasteful buffering 

    This refines 9ce4bd4 by only buffering if we’re actually inside an
attribute value.
    @sideshowbarker
    sideshowbarker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    8010453 View commit details
    Browse the repository at this point in the history
Loading