fix: all test cases pass on my machine, yay

Author: ntamas

src/_igraph/attributes.c

@@ -413,7 +413,7 @@ static int igraphmodule_i_attribute_copy(igraph_t *to, const igraph_t *from,
 }
 
 /* Adding vertices */
-static int igraphmodule_i_attribute_add_vertices(igraph_t *graph, long int nv, igraph_vector_ptr_t *attr) {
+static int igraphmodule_i_attribute_add_vertices(igraph_t *graph, igraph_integer_t nv, igraph_vector_ptr_t *attr) {
   /* Extend the end of every value in the vertex hash with nv pieces of None */
   PyObject *key, *value, *dict;
   long int i, j, k, l;

src/_igraph/convert.c

@@ -1337,6 +1337,7 @@ PyObject* igraphmodule_vector_int_t_to_PyList(const igraph_vector_int_t *v) {
 
   list=PyList_New(n);
   for (i=0; i<n; i++) {
+    /* TODO: what if igraph_integer_t is larger than a long? */
     item = PyLong_FromLong((long)VECTOR(*v)[i]);
     if (!item) {
       Py_DECREF(list);

src/_igraph/edgeseqobject.c

@@ -46,7 +46,7 @@ PyTypeObject igraphmodule_EdgeSeqType;
  * \return the allocated PyObject
  */
 PyObject* igraphmodule_EdgeSeq_new(PyTypeObject *subtype,
-	PyObject *args, PyObject *kwds) {
+  PyObject *args, PyObject *kwds) {
   igraphmodule_EdgeSeqObject* o;
 
   o=(igraphmodule_EdgeSeqObject*)PyType_GenericNew(subtype, args, kwds);
@@ -124,7 +124,7 @@ int igraphmodule_EdgeSeq_init(igraphmodule_EdgeSeqObject *self,
     }
     igraph_es_1(&es, (igraph_integer_t)idx);
   } else {
-	/* We selected multiple edges */
+  /* We selected multiple edges */
     igraph_vector_int_t v;
     igraph_integer_t n = igraph_ecount(&((igraphmodule_GraphObject*)g)->g);
     if (igraphmodule_PyObject_to_vector_int_t(esobj, &v))
@@ -228,9 +228,17 @@ PyObject* igraphmodule_EdgeSeq_sq_item(igraphmodule_EdgeSeqObject* self,
       }
       break;
 
+    case IGRAPH_ES_NONE:
+      break;
+
     /* TODO: IGRAPH_ES_PAIRS, IGRAPH_ES_ADJ, IGRAPH_ES_PATH,
        IGRAPH_ES_MULTIPATH - someday :) They are unused yet in the Python
        interface */
+
+    default:
+      return PyErr_Format(
+        igraphmodule_InternalError, "unsupported edge selector type: %d", igraph_es_type(&self->es)
+      );
   }
   if (idx < 0) {
     PyErr_SetString(PyExc_IndexError, "edge index out of range");

src/_igraph/graphobject.c

@@ -6352,32 +6352,32 @@ typedef struct {
   PyObject* graph;
 } igraphmodule_i_Graph_motifs_randesu_callback_data_t;
 
-igraph_bool_t igraphmodule_i_Graph_motifs_randesu_callback(const igraph_t *graph,
-    igraph_vector_t *vids, int isoclass, void* extra) {
+igraph_error_t igraphmodule_i_Graph_motifs_randesu_callback(const igraph_t *graph,
+    igraph_vector_int_t *vids, int isoclass, void* extra) {
   igraphmodule_i_Graph_motifs_randesu_callback_data_t* data =
     (igraphmodule_i_Graph_motifs_randesu_callback_data_t*)extra;
   PyObject* vector;
   PyObject* result;
   igraph_bool_t retval;
 
-  vector = igraphmodule_vector_t_to_PyList(vids, IGRAPHMODULE_TYPE_INT);
+  vector = igraphmodule_vector_int_t_to_PyList(vids);
   if (vector == NULL) {
     /* Error in conversion, return 1 */
-    return 1;
+    return IGRAPH_FAILURE;
   }
 
   result = PyObject_CallFunction(data->func, "OOi", data->graph, vector, isoclass);
   Py_DECREF(vector);
 
   if (result == NULL) {
     /* Error in callback, return 1 */
-    return 1;
+    return IGRAPH_FAILURE;
   }
 
   retval = PyObject_IsTrue(result);
   Py_DECREF(result);
 
-  return retval;
+  return retval ? IGRAPH_STOP : IGRAPH_SUCCESS;
 }
 
 /** \ingroup python_interface_graph
@@ -8819,17 +8819,17 @@ igraph_bool_t igraphmodule_i_Graph_isomorphic_vf2_callback_fn(
 
   map12_o = igraphmodule_vector_int_t_to_PyList(map12);
   if (map12_o == NULL) {
-    /* Error in conversion, return 0 to stop the search */
+    /* Error in conversion, return an error code */
     PyErr_WriteUnraisable(data->callback_fn);
-    return 0;
+    return IGRAPH_FAILURE;
   }
 
   map21_o = igraphmodule_vector_int_t_to_PyList(map21);
   if (map21_o == NULL) {
-    /* Error in conversion, return 0 to stop the search */
+    /* Error in conversion, return an error code */
     PyErr_WriteUnraisable(data->callback_fn);
     Py_DECREF(map21_o);
-    return 0;
+    return IGRAPH_FAILURE;
   }
 
   result = PyObject_CallFunction(data->callback_fn, "OOOO", data->graph1, data->graph2,
@@ -8838,15 +8838,15 @@ igraph_bool_t igraphmodule_i_Graph_isomorphic_vf2_callback_fn(
   Py_DECREF(map21_o);
 
   if (result == NULL) {
-    /* Error in callback, return 0 */
+    /* Error in callback, return an error code */
     PyErr_WriteUnraisable(data->callback_fn);
-    return 0;
+    return IGRAPH_FAILURE;
   }
 
   retval = PyObject_IsTrue(result);
   Py_DECREF(result);
 
-  return retval;
+  return retval ? IGRAPH_SUCCESS : IGRAPH_STOP;
 }
 
 igraph_bool_t igraphmodule_i_Graph_isomorphic_vf2_node_compat_fn(

src/_igraph/vertexseqobject.c

@@ -213,6 +213,8 @@ PyObject* igraphmodule_VertexSeq_sq_item(igraphmodule_VertexSeqObject* self,
         idx = self->vs.data.vid;
       }
       break;
+    case IGRAPH_VS_NONE:
+      break;
     case IGRAPH_VS_SEQ:
       if (i < 0) {
         i = self->vs.data.seq.to - self->vs.data.seq.from + i;
@@ -223,6 +225,10 @@ PyObject* igraphmodule_VertexSeq_sq_item(igraphmodule_VertexSeqObject* self,
       break;
     /* TODO: IGRAPH_VS_ADJ, IGRAPH_VS_NONADJ - someday :) They are unused
        yet in the Python interface */
+    default:
+      return PyErr_Format(
+        igraphmodule_InternalError, "unsupported vertex selector type: %d", igraph_vs_type(&self->vs)
+      );
   }
 
   if (idx < 0) {