Skip to content

Commit 5749af0

Browse files
epetrowJuveniel
authored andcommitted
feat(notification): unify groups rendering
Important changes: - remove `k-notification-container` class and related styles
1 parent e8eb822 commit 5749af0

7 files changed

Lines changed: 27 additions & 21 deletions

File tree

packages/bootstrap/scss/notification/_variables.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// Notification
22

3+
/// The row-gap between the elements in the Notification group.
4+
/// @group notification
5+
$kendo-notification-group-gap: k-map-get( $kendo-spacing, 3 ) !default;
6+
37
/// The horizontal padding of the Notification.
48
/// @group notification
59
$kendo-notification-padding-x: $alert-padding-x !default;

packages/classic/scss/notification/_variables.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
// Notification
22

3+
4+
/// The row-gap between the elements in the Notification group.
5+
/// @group notification
6+
$kendo-notification-group-gap: k-map-get( $kendo-spacing, 2 ) !default;
7+
38
/// The horizontal padding of the Notification.
49
/// @group notification
510
$kendo-notification-padding-x: 8px !default;

packages/default/scss/notification/_layout.scss

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,12 @@
77
flex-flow: column-reverse wrap;
88
position: fixed;
99
z-index: 1000;
10+
gap: $kendo-notification-group-gap 0;
1011
}
1112

12-
.k-notification-container {
13-
margin-block: k-math-div( $kendo-notification-padding-y, 2 );
14-
margin-inline: 0;
15-
display: inline-flex;
16-
vertical-align: top;
17-
18-
&-animating {
19-
overflow: hidden;
20-
}
13+
// Needed due to the specifics in the implementation of animations in Angular
14+
.k-notification-container-animating {
15+
overflow: hidden;
2116
}
2217

2318
.k-notification {

packages/default/scss/notification/_variables.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// Notification
22

3+
/// The row-gap between the elements in the Notification group.
4+
/// @group notification
5+
$kendo-notification-group-gap: k-map-get( $kendo-spacing, 2 ) !default;
6+
37
/// The horizontal padding of the Notification.
48
/// @group notification
59
$kendo-notification-padding-x: 8px !default;

packages/fluent/scss/notification/_layout.scss

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,12 @@
1010
flex-flow: column-reverse wrap;
1111
position: fixed;
1212
z-index: 1000;
13+
gap: var( --kendo-notificaiton-group-gap, #{$kendo-notification-group-gap} ) 0;
1314
}
1415

15-
.k-notification-container {
16-
margin-block: var( --kendo-notification-container-padding-y, #{$kendo-notification-container-padding-y} );
17-
margin-inline: 0;
18-
display: inline-flex;
19-
vertical-align: top;
20-
21-
&-animating {
22-
overflow: hidden;
23-
}
16+
// Needed due to the specifics in the implementation of animations in Angular
17+
.k-notification-container-animating {
18+
overflow: hidden;
2419
}
2520

2621
.k-notification {

packages/fluent/scss/notification/_variables.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
@use "sass:map";
22
@use "../core/" as *;
33

4-
/// The vertical padding of the Notification container.
4+
/// The row-gap between the elements in the Notification group.
55
/// @group notification
6-
$kendo-notification-container-padding-y: $kendo-padding-sm-y !default;
6+
$kendo-notification-group-gap: map.get( $kendo-spacing, 2 ) !default;
77

88
/// The horizontal padding of the Notification.
99
/// @group notification

packages/material/scss/notification/_variables.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// Notification
22

3+
/// The row-gap between the elements in the Notification group.
4+
/// @group notification
5+
$kendo-notification-group-gap: k-map-get( $kendo-spacing, 2 ) !default;
6+
37
/// The horizontal padding of the Notification.
48
/// @group notification
59
$kendo-notification-padding-x: 16px !default;
@@ -38,7 +42,6 @@ $kendo-notification-shadow: $kendo-popup-shadow !default;
3842
/// @group notification
3943
$kendo-notification-icon-spacing: $kendo-icon-spacing !default;
4044

41-
4245
@function notification-theme( $colors ) {
4346
$_theme: ();
4447

0 commit comments

Comments
 (0)