Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] StripeCardScan ScanCard only has the card number and no expiration date #2875

Open
Tracked by #2885
littlematt opened this issue Aug 24, 2023 · 10 comments
Open
Tracked by #2885

[Feature] StripeCardScan ScanCard only has the card number and no expiration date #2875

littlematt opened this issue Aug 24, 2023 · 10 comments
Labels
CardScan kind:improvement

Comments

@littlematt
Copy link

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.
@seanzhang-stripe
Copy link

seanzhang-stripe commented Aug 24, 2023 •
edited
Loading

Hi @littlematt . Can you share with us more about the problem that you are facing? Any relevant code snippet, screenshots or screen recordings, as well as the version of the SDK will be helpful here.

@littlematt
Copy link
Author

Hi @littlematt . Can you share with us more about the problem that you are facing? Any relevant code snippet, screenshots or screen recordings, as well as the version of the SDK will be helpful here.

Hi，When the SDK recognizes the bank card, it only recognizes the bank card number, but it does not recognize the expiration date

@littlematt
Copy link
Author

Hi @littlematt . Can you share with us more about the problem that you are facing? Any relevant code snippet, screenshots or screen recordings, as well as the version of the SDK will be helpful here.

Hi, the model ScanCard has only one field "pan"

@seanzhang-stripe
Copy link

Hi @littlematt are you referring to the ScannedCard structure?

I've added your request to our internal backlog.

@sunshinejr
Copy link

+1 on this one, as this is something we are also interested in :)

@Belinskaya
Copy link

+1 on this one. The bummer is that internal classes do recognize whole card information. But unfortunately ScannedCard has only 1 property for pan. And above mentioned classes are not public. I even can't override userDidScanCardSimple in CardScanSheet, because it's in extension. So no way to solve this on my own.

@Belinskaya
Copy link

hey @seanzhang-stripe do you know a timeline for this?

@via-guy
Copy link

via-guy commented Feb 28, 2024

This is an issue for us too. We're not sure why those other values are blocked.
Also, is it possible to get the CVV as well? E.g. from an AMEX card?

@via-guy
Copy link

via-guy commented Feb 28, 2024

This is also a duplicate of #2484

via-guy added a commit to via-guy/stripe-ios that referenced this issue Mar 1, 2024
@via-guy
Makes the scanned name and expiry date of a card publicly visible
9dae684 
Fixes stripe#2875 and stripe#2484
@via-guy via-guy mentioned this issue Mar 1, 2024
Closed
@sgrant-stripe sgrant-stripe mentioned this issue Apr 25, 2024
Merged
sgrant-stripe added a commit that referenced this issue Apr 26, 2024
@sgrant-stripe
Makes the scanned name and expiry date of a card publicly visible (#3539
b0b8966 
)

## Summary
Remove `@_spi` for `ScannedCard` properties.
Fixes #2484 and #2875

## Motivation
In order to autofill our card entry form we need the scanned details,
but for some reason they're blocked from being publicly visible.

## Testing
N/A

## Changelog
[Changed] `ScannedCard` to allow access for `expiryMonth`, `expiryYear`
and `name`.
@davidme-stripe
Copy link
Contributor

This was fixed in #3539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CardScan kind:improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sunshinejr @Belinskaya @littlematt @davidme-stripe @via-guy @seanzhang-stripe @sfriedman-stripe