When executing a statement, we want to make sure any previous state

was cleaned up, so the code was calling close().  This additionally
set a closed flag which would throw exceptions later saying that you
can't call various methods because the Statement is closed.  It's
not actually closed, so split the internal cleanup routine to clear()
and make close() something that only a user should call.

Author: kjurka

src/java/pljava/org/postgresql/pljava/jdbc/SPIStatement.java

@@ -34,7 +34,7 @@ public class SPIStatement implements Statement
 	private ResultSet m_resultSet      = null;
 	private int       m_updateCount    = 0;
 	private ArrayList m_batch          = null;
-    private boolean   m_closed         = false;
+	private boolean   m_closed         = false;
 
 	public SPIStatement(SPIConnection conn)
 	{
@@ -66,7 +66,7 @@ public void clearWarnings()
 	{
 	}
 
-	public void close()
+	private void clear()
 	throws SQLException
 	{
 		if(m_resultSet != null)
@@ -79,15 +79,22 @@ public void close()
 		m_updateCount = -1;
 		m_cursorName = null;
 		m_batch = null;
-        m_closed = true;
+	}
+
+	public void close()
+	throws SQLException
+	{
+		clear();
+		m_closed = true;
 	}
 
 	public boolean execute(String statement)
 	throws SQLException
 	{
-		// Ensure that the statement is closed before we re-execute
+		// Ensure that the last statement is cleaned up
+		// before we re-execute
 		//
-		this.close();
+		this.clear();
 
 		ExecutionPlan plan = ExecutionPlan.prepare(
 			m_connection.nativeSQL(statement), null);
@@ -310,9 +317,9 @@ public int getUpdateCount()
 	public SQLWarning getWarnings()
 	throws SQLException
 	{
-        if (m_closed) {
-            throw new SQLException("getWarnings: Statement is closed");
-        }
+		if (m_closed) {
+			throw new SQLException("getWarnings: Statement is closed");
+		}
 
 		return null;
 	}
@@ -390,4 +397,4 @@ void resultSetClosed(ResultSet rs)
 		if(rs == m_resultSet)
 			m_resultSet = null;
 	}
-}
+}