feat: Enable Indexing of array fields#3092
Merged
islamaliev merged 26 commits intosourcenetwork:developfrom Oct 4, 2024
Merged
feat: Enable Indexing of array fields#3092islamaliev merged 26 commits intosourcenetwork:developfrom
islamaliev merged 26 commits intosourcenetwork:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3092 +/- ##
===========================================
+ Coverage 79.81% 79.99% +0.18%
===========================================
Files 351 352 +1
Lines 27335 27757 +422
===========================================
+ Hits 21816 22204 +388
- Misses 3982 3987 +5
- Partials 1537 1566 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
reviewed
Oct 2, 2024
shahzadlone
reviewed
Oct 2, 2024
shahzadlone
reviewed
Oct 2, 2024
shahzadlone
reviewed
Oct 2, 2024
shahzadlone
reviewed
Oct 2, 2024
AndrewSisley
requested changes
Oct 3, 2024
Contributor
AndrewSisley
left a comment
There was a problem hiding this comment.
Part way through reviewing, looks really great so far, only very localised comments atm :)
AndrewSisley
requested changes
Oct 3, 2024
Contributor
AndrewSisley
left a comment
There was a problem hiding this comment.
Looks really good Islam, just a couple more todos from me before merge
AndrewSisley
approved these changes
Oct 4, 2024
Contributor
AndrewSisley
left a comment
There was a problem hiding this comment.
Looks really good Islam, thanks for this :)
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#2279 ## Description Enable indexing of array fields. This change also adds `Equal` method to `NormalValue`.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Apr 25, 2025
## Relevant issue(s) Resolves sourcenetwork#2279 ## Description Enable indexing of array fields. This change also adds `Equal` method to `NormalValue`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2279
Description
Enable indexing of array fields.
This change also adds
IsEqualmethod toNormalValue.