Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coatue-oss/react2angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: simon360/react2angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 1, 2019

  1. Remove @types packages from peerDependencies 

    This project uses typescript in its development - but by the time it's published to NPM, it's compiled down to vanilla JS. The @types packages which were specified in
peerDependencies would be useful for consumers that use typescript, but: 1. those users will already know to install those @types packages, because that's how React and
Angular get their types, and 2. the users who _don't_ use typescript will get warnings Those types are more accurately peer dependencies _for React and Angular_, and _only
when tuypescript is in use_.

In order to kill off those extraneous warnings, I've removed those packages from peerDependencies. It should have no impact on the package itself, only the warnings produced
when installed.
    @simon360
    simon360 committed May 1, 2019
    Configuration menu
    Copy the full SHA
    1105451 View commit details
    Browse the repository at this point in the history
Loading