Skip to content

Commit f96af70

Browse files
mekarpelesroot
authored andcommitted
more thrillers performance tuning + tests
1 parent 3c798fa commit f96af70

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

openlibrary/plugins/openlibrary/home.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def GET(self):
4545
return page
4646

4747
CAROUSELS_PRESETS = {
48-
'preset:thrillers': '(creator:"Stephen King" OR creator:"Tom Clancy" OR creator:"Clancy, Tom" OR creator:"King, Stephen" OR creator:"Clive Cussler" OR creator:("Cussler, Clive") OR creator:("Dean Koontz") OR creator:("Koontz, Dean") OR creator:("Jack Higgins") OR creator:("Higgins, Jack")) AND !publisher:"Pleasantville, N.Y. : Reader\'s Digest Association" AND languageSorter:"English"'
48+
'preset:thrillers': '(creator:"Clancy, Tom" OR creator:"King, Stephen" OR creator:"Clive Cussler" OR creator:("Cussler, Clive") OR creator:("Dean Koontz") OR creator:("Koontz, Dean") OR creator:("Higgins, Jack")) AND !publisher:"Pleasantville, N.Y. : Reader\'s Digest Association" AND languageSorter:"English"'
4949
}
5050

5151
def get_ia_carousel_books(query=None, subject=None, sorts=None, limit=None):
@@ -57,15 +57,14 @@ def get_ia_carousel_books(query=None, subject=None, sorts=None, limit=None):
5757

5858
limit = limit or lending.DEFAULT_IA_RESULTS
5959
books = lending.get_available(limit=limit, subject=subject, sorts=sorts, query=query)
60-
print(books)
6160
formatted_books = [format_book_data(book) for book in books if book != 'error']
6261
return formatted_books
6362

6463
@public
65-
def generic_carousel(key, query=None, subject=None, sorts=None, limit=None):
64+
def generic_carousel(key, query=None, subject=None, sorts=None, limit=None, timeout=None):
6665
memcache_key = 'home.ia_carousel_books'
6766
cached_ia_carousel_books = cache.memcache_memoize(
68-
get_ia_carousel_books, memcache_key, timeout=DEFAULT_CACHE_LIFETIME)
67+
get_ia_carousel_books, memcache_key, timeout=timeout or DEFAULT_CACHE_LIFETIME)
6968
books = cached_ia_carousel_books(query=query, subject=subject, sorts=sorts, limit=limit)
7069
random.shuffle(books)
7170
return storify(books)

openlibrary/plugins/openlibrary/tests/test_home.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def spoofed_generic_carousel(*args, **kwargs):
120120
html = unicode(render_template("home/index", stats=stats, test=True))
121121

122122
headers = ["Books We Love", "Recently Returned", "Success",
123-
"College Prep", "Romance", "Cooking", "Technical Books",
123+
"Thrillers", "Romance", "Technical Books",
124124
"Classic Literature", "Textbooks", "Science Fiction",
125125
"Biographies", "Mysteries"]
126126

0 commit comments

Comments
 (0)