Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scientific-python/specs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: scientific-python/specs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nep7-prng
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 1 file changed
  • 6 contributors

Commits on Jun 4, 2024

  1. Add draft SPEC7: seeding pseudo-random number generation

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b233242 View commit details
    Browse the repository at this point in the history

  2. Add deprecation strategy

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1e0d3f9 View commit details
    Browse the repository at this point in the history

  3. Explain why globally seeded code will become unseeded

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    009453f View commit details
    Browse the repository at this point in the history

  4. Integrate some reviewer feedback

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    cfa4fd8 View commit details
    Browse the repository at this point in the history

  5. Adjust based on #180 (comment)

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9bf299a View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @stefanv
    stefanv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    fb64c31 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Add code snippet to SPEC 7 (as proposed for SciPy)

    @seberg
    seberg committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d55c0b2 View commit details
    Browse the repository at this point in the history

  2. Add a library function example

    @seberg
    seberg committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    935fed2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Stefan van der Walt <[email protected]>
    @seberg @stefanv
    seberg and stefanv authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a17eba9 View commit details
    Browse the repository at this point in the history

  2. Fix implementation note about random.seed()

    @seberg
    seberg committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0703ee8 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge pull request #1 from seberg/nep7-prng 

    Add code snippet for the rng conversion (as proposed to scipy)
    @stefanv
    stefanv authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3fd8fc7 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add Pamphile as co-author 

    Co-authored-by: Pamphile Roy <[email protected]>
    @stefanv @tupui
    stefanv and tupui authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7c163df View commit details
    Browse the repository at this point in the history

  2. Add @lagru's keyword-only suggestion 

    Co-authored-by: Lars Grüter <[email protected]>
    @stefanv @lagru
    stefanv and lagru authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e2d6541 View commit details
    Browse the repository at this point in the history

  3. Appease linter

    @stefanv
    stefanv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9894af0 View commit details
    Browse the repository at this point in the history

  4. Add @ilayn's suggestion to separate high-level goals and technical re… 

    …commendations
    @stefanv
    stefanv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8d89cc8 View commit details
    Browse the repository at this point in the history

  5. Add type annotation

    @stefanv
    stefanv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    151d68d View commit details
    Browse the repository at this point in the history

  6. How to transition away from np.random.seed

    @stefanv
    stefanv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5491549 View commit details
    Browse the repository at this point in the history
Loading