From 4f514b929344bd18a6e5a32da3e44156b4c92b24 Mon Sep 17 00:00:00 2001 From: Werner Altewischer Date: Mon, 3 Feb 2025 15:40:58 +0100 Subject: [PATCH 1/5] Fixed warning --- CMakeLists.txt | 2 +- unpacker.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 936d494..8642aa5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.2) +cmake_minimum_required(VERSION 3.5.0) project(msgpack VERSION 0.0.1 LANGUAGES C CXX) option(ENABLE_TESTING "ENABLE_TESTING" OFF) diff --git a/unpacker.h b/unpacker.h index 5a16f5e..9304ae3 100644 --- a/unpacker.h +++ b/unpacker.h @@ -66,7 +66,7 @@ class unpacker { explicit unpacker(const buffer_type& buf) : _buffer(std::make_shared(buf)), _it{ _buffer->cbegin() }, _it_end{ _buffer->cend() } {} explicit unpacker(buffer_type&& buf) - : _buffer(std::make_shared(move(buf))), _it{ _buffer->cbegin() }, _it_end{ _buffer->cend() } {} + : _buffer(std::make_shared(std::move(buf))), _it{ _buffer->cbegin() }, _it_end{ _buffer->cend() } {} inline unpacker& operator>>(bool& value); inline unpacker& operator>>(int8_t& value); From 5cfc0ca9496b7548cbae588c57bfabd2e43ba7e1 Mon Sep 17 00:00:00 2001 From: Werner Altewischer Date: Tue, 4 Feb 2025 11:58:02 +0100 Subject: [PATCH 2/5] Updated min version of CMAKE to 3.10.0 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8642aa5..0b13c60 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.5.0) +cmake_minimum_required(VERSION 3.10.0) project(msgpack VERSION 0.0.1 LANGUAGES C CXX) option(ENABLE_TESTING "ENABLE_TESTING" OFF) From b5d0e3eddebef43dbce13382b89a603256478f04 Mon Sep 17 00:00:00 2001 From: Werner Altewischer Date: Tue, 4 Feb 2025 18:17:16 +0100 Subject: [PATCH 3/5] Hopefully fixed build under Linux --- CMakeLists.txt | 2 +- packer.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0b13c60..883456e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -5,7 +5,7 @@ option(ENABLE_TESTING "ENABLE_TESTING" OFF) option(ENABLE_BENCHMARKING "ENABLE_BENCHMARKING" OFF) option(ENABLE_TRAVIS "ENABLE_TRAVIS" OFF) -set(CMAKE_CXX_STANDARD 11) +set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") diff --git a/packer.h b/packer.h index 47f90d7..04c466e 100644 --- a/packer.h +++ b/packer.h @@ -9,6 +9,7 @@ #include #include #include "platform.h" +#include #include namespace msgpack { From b31bc8326e2ef72832534c7af58e1e1bd229ddc6 Mon Sep 17 00:00:00 2001 From: Werner Altewischer Date: Mon, 17 Feb 2025 16:33:27 +0100 Subject: [PATCH 4/5] Updated C++ standard to 17 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 883456e..6c11609 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -5,7 +5,7 @@ option(ENABLE_TESTING "ENABLE_TESTING" OFF) option(ENABLE_BENCHMARKING "ENABLE_BENCHMARKING" OFF) option(ENABLE_TRAVIS "ENABLE_TRAVIS" OFF) -set(CMAKE_CXX_STANDARD 14) +set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") From aaf0369144ebc14b962be6e3d9162cab6c1e8521 Mon Sep 17 00:00:00 2001 From: Werner Altewischer Date: Wed, 19 Feb 2025 07:31:09 +0100 Subject: [PATCH 5/5] TECH-7 Raised min CMake version to 3.15.0 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6c11609..54550c0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.10.0) +cmake_minimum_required(VERSION 3.15.0) project(msgpack VERSION 0.0.1 LANGUAGES C CXX) option(ENABLE_TESTING "ENABLE_TESTING" OFF)