Remove COMDAT support in the next release

[bjorn3]

According to #20 (comment) it turns out that it isn't actually supported by the linker after all.

[ChrisDenton]

I've taken a simpler approach in ChrisDenton@a5b424a which I've more thoroughly tested as working. Not PRing it yet unless/until rust-lang/rust#129257 comes back green.

If that works, we can probably just rename the flag to something more generic without breaking the interface (I used whole_archive_compat in my experiment).

[ChrisDenton]

@bjorn3 it looks like the published version is from an old commit? Looking at the published source, it doesn't seem to have the latest changes.

Published: https://docs.rs/crate/ar_archive_writer/0.4.1/source/src/coff_import_file.rs#215 and
Master:

ar_archive_writer/src/coff_import_file.rs

Line 216 in b54f093

fn new(s: &'a str, m: MachineTypes, whole_archive_compat: bool) -> Result<Self> {

[bjorn3]

Forgot to pull before I published... Published as v0.4.2. The commit for v0.4.1 has been orphaned, but is still available under the v0.4.1 tag.

#21 would have helped avoid this.

[ChrisDenton]

Ah thanks!