Skip to content

Commit 094909a

Browse files
DimitrisJimbrettcannon
authored andcommitted
Remove outdated tests in test_isinstance (pythonGH-1393)
There is no need to test for new-style classes versus classic classes in Python 3.
1 parent f06e021 commit 094909a

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

Lib/test/test_isinstance.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -177,15 +177,6 @@ class Super:
177177

178178
class Child(Super):
179179
pass
180-
181-
# new-style classes
182-
class NewSuper(object):
183-
pass
184-
185-
class NewChild(NewSuper):
186-
pass
187-
188-
189180

190181
class TestIsInstanceIsSubclass(unittest.TestCase):
191182
# Tests to ensure that isinstance and issubclass work on abstract
@@ -247,15 +238,8 @@ def test_subclass_tuple(self):
247238
self.assertEqual(False, issubclass(Child, ()))
248239
self.assertEqual(True, issubclass(Super, (Child, (Super,))))
249240

250-
self.assertEqual(True, issubclass(NewChild, (NewChild,)))
251-
self.assertEqual(True, issubclass(NewChild, (NewSuper,)))
252-
self.assertEqual(False, issubclass(NewSuper, (NewChild,)))
253-
self.assertEqual(True, issubclass(NewSuper, (NewChild, NewSuper)))
254-
self.assertEqual(False, issubclass(NewChild, ()))
255-
self.assertEqual(True, issubclass(NewSuper, (NewChild, (NewSuper,))))
256-
257241
self.assertEqual(True, issubclass(int, (int, (float, int))))
258-
self.assertEqual(True, issubclass(str, (str, (Child, NewChild, str))))
242+
self.assertEqual(True, issubclass(str, (str, (Child, str))))
259243

260244
def test_subclass_recursion_limit(self):
261245
# make sure that issubclass raises RecursionError before the C stack is

0 commit comments

Comments
 (0)