From ed3385a33664b5fd9fc4b0cf1c89be7d33158ddc Mon Sep 17 00:00:00 2001 From: Joel Denning Date: Mon, 16 Dec 2024 19:27:59 -0700 Subject: [PATCH 1/5] First try at react 19 --- importmap-template.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/importmap-template.json b/importmap-template.json index b57d875..c219e24 100644 --- a/importmap-template.json +++ b/importmap-template.json @@ -1,8 +1,8 @@ { "imports": { "single-spa": "7.0.0-beta.1", - "react": "18.3.1", - "react-dom": "18.3.1", + "react": "19.0.0", + "react-dom": "19.0.0", "rxjs": "7.8.1" }, "scopes": { From 4f98c65bb41eca37d6ad4f05c12cfd480d8b2f3e Mon Sep 17 00:00:00 2001 From: Joel Denning Date: Mon, 16 Dec 2024 19:29:44 -0700 Subject: [PATCH 2/5] Add react-dom client --- importmap-template.json | 1 + 1 file changed, 1 insertion(+) diff --git a/importmap-template.json b/importmap-template.json index c219e24..d36d8e0 100644 --- a/importmap-template.json +++ b/importmap-template.json @@ -3,6 +3,7 @@ "single-spa": "7.0.0-beta.1", "react": "19.0.0", "react-dom": "19.0.0", + "react-dom/client": "19.0.0", "rxjs": "7.8.1" }, "scopes": { From 479bd59fd3a48497ae15ae7ec1d05a3c4eceb446 Mon Sep 17 00:00:00 2001 From: Joel Denning Date: Mon, 16 Dec 2024 20:09:37 -0700 Subject: [PATCH 3/5] Try branch --- .github/workflows/build_and_deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index b0c0707..a37b1fb 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -14,7 +14,7 @@ jobs: - name: Checkout Repo uses: actions/checkout@v4 - name: Build Global Script Dependencies - uses: single-spa/action-build-global-script-deps@v1 + uses: single-spa/action-build-global-script-deps@upgrade-deps with: global-scripts: ./global-scripts.json output-folder: dist/deps From 5d8b20fead2552589eb4348ac5ceccc4cbfe95af Mon Sep 17 00:00:00 2001 From: Joel Denning Date: Mon, 16 Dec 2024 20:14:26 -0700 Subject: [PATCH 4/5] Fix --- .github/workflows/build_and_deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index a37b1fb..b0c0707 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -14,7 +14,7 @@ jobs: - name: Checkout Repo uses: actions/checkout@v4 - name: Build Global Script Dependencies - uses: single-spa/action-build-global-script-deps@upgrade-deps + uses: single-spa/action-build-global-script-deps@v1 with: global-scripts: ./global-scripts.json output-folder: dist/deps From 87eb807b9468bf6c13925bf7c4ce4214703e9b07 Mon Sep 17 00:00:00 2001 From: Joel Denning Date: Mon, 16 Dec 2024 20:15:07 -0700 Subject: [PATCH 5/5] Use v1 --- .github/workflows/build_and_deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index b0c0707..83a048a 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -19,7 +19,7 @@ jobs: global-scripts: ./global-scripts.json output-folder: dist/deps - name: Build Import Map - uses: single-spa/action-build-import-map-microfrontend-deps@dependencies-folder + uses: single-spa/action-build-import-map-microfrontend-deps@v1 with: import-map-template: ./importmap-template.json output-folder: dist