Skip to content

Commit ebc90be

Browse files
committed
Merge branch 'drm-tda998x-fixes' of git://ftp.arm.linux.org.uk/~rmk/linux-arm
Pull TDA998x i2c driver fixes from Russell King: "This fixes the double-checksumming of the AVI infoframe which was resulting in the checksum always being zero. It went unnoticed as none of my HDMI devices had a problem with this" [ Pulling directly from rmk since Dave Airlie is on vacation - Linus ] * 'drm-tda998x-fixes' of git://ftp.arm.linux.org.uk/~rmk/linux-arm: drm/i2c: tda998x: fix bad checksum of the HDMI AVI infoframe
2 parents 4469942 + 4a6ca1a commit ebc90be

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/i2c/tda998x_drv.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,6 @@ static void
606606
tda998x_write_if(struct tda998x_priv *priv, uint8_t bit, uint16_t addr,
607607
uint8_t *buf, size_t size)
608608
{
609-
buf[PB(0)] = tda998x_cksum(buf, size);
610-
611609
reg_clear(priv, REG_DIP_IF_FLAGS, bit);
612610
reg_write_range(priv, addr, buf, size);
613611
reg_set(priv, REG_DIP_IF_FLAGS, bit);
@@ -627,6 +625,8 @@ tda998x_write_aif(struct tda998x_priv *priv, struct tda998x_encoder_params *p)
627625
buf[PB(4)] = p->audio_frame[4];
628626
buf[PB(5)] = p->audio_frame[5] & 0xf8; /* DM_INH + LSV */
629627

628+
buf[PB(0)] = tda998x_cksum(buf, sizeof(buf));
629+
630630
tda998x_write_if(priv, DIP_IF_FLAGS_IF4, REG_IF4_HB0, buf,
631631
sizeof(buf));
632632
}

0 commit comments

Comments
 (0)