fix(storage-azure): fix azure storage mime type handling for streaming uploads#15949
Merged
paulpopus merged 1 commit intopayloadcms:mainfrom Apr 2, 2026
Merged
Conversation
paulpopus
approved these changes
Apr 2, 2026
Contributor
|
🚀 This is included in version v3.82.0 |
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…g uploads (payloadcms#15949) The fix itself is quite simple, the code was just missing the content type header when uploading via streams. I think the actual code review is more about the testing. I'm not sure if I did everything right. I've duplicated the current azure storage tests and made sure to run them with `useTempFiles: true` which causes all uploads to be streaming uploads. I've also added the test for the mime type handling to the original test suite just to be sure that it is also tested for non-streaming uploads. closes payloadcms#15948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix itself is quite simple, the code was just missing the content type header when uploading via streams.
I think the actual code review is more about the testing. I'm not sure if I did everything right.
I've duplicated the current azure storage tests and made sure to run them with
useTempFiles: truewhich causes all uploads to be streaming uploads. I've also added the test for the mime type handling to the original test suite just to be sure that it is also tested for non-streaming uploads.closes #15948