Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"projectsAffectedByDependencyUpdates": "auto" does not work with pnpm catalogs #29986

Open
1 of 4 tasks
laneysmith opened this issue Feb 11, 2025 · 1 comment
Open
1 of 4 tasks

Comments

@laneysmith
Copy link
Contributor

Current Behavior

To help enforce a single version policy within our monorepo, we use pnpm catalogs for all dependencies that are used in multiple projects. When "projectsAffectedByDependencyUpdates" is set to "auto", updates to pnpm-workspace.yaml catalog versions result in 0 projects being marked as affected.

Expected Behavior

When a default or named catalog version is updated in pnpm-workspace.yaml, all projects that reference that catalog as a dependency in their package.json should be marked as affected.

GitHub Repo

No response

Steps to Reproduce

In any Nx workspace project that uses catalogs,

  1. set "projectsAffectedByDependencyUpdates" to "auto" & commit change
  2. update a version for a catalog dependency
  3. run pnpm i
  4. run nx show projects --affected --uncommitted

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.17.0
OS             : darwin-arm64
Native Target  : aarch64-macos
pnpm           : 9.11.0

nx                     : 20.3.2
@nx/js                 : 20.3.2
@nx/jest               : 20.3.2
@nx/eslint             : 20.3.2
@nx/workspace          : 20.3.2
@nx/cypress            : 20.3.2
@nx/devkit             : 20.3.2
@nx/eslint-plugin      : 20.3.2
@nx/module-federation  : 20.3.2
@nx/plugin             : 20.3.2
@nx/react              : 20.3.2
@nx/storybook          : 20.3.2
@nx/vite               : 20.3.2
@nx/web                : 20.3.2
typescript             : 5.5.4
---------------------------------------
Registered Plugins:
@nx/vite/plugin
@nx/storybook/plugin
@nx/js/typescript

Failure Logs

Package Manager Version

9.11.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Related to the following issues that stem from lack of support for pnpm catalogs

@ryanbas21
Copy link
Contributor

#29923 Does this help? Let me know if i'm missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants