From 58296e4ec12f97ad7b74ba7a2fe9952b014e8d7e Mon Sep 17 00:00:00 2001
From: Tom Gallacher <tomgallacher23@gmail.com>
Date: Fri, 30 Oct 2015 08:18:00 -0400
Subject: [PATCH] buffer: Fixing deopt when constructed with strings

When a buffer was created using `new Buffer('A String')`, internally
within the buffer class we would read arguments[1], however in this case
we would be reading outside of the array causing a deopt to occur.

This fixes this issue by casting the type to a string before use, and
removing the usage of the arguments object.
---
 lib/buffer.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lib/buffer.js b/lib/buffer.js
index dec02ed8e70a6e..953ee6abb5f770 100644
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -40,7 +40,7 @@ function alignPool() {
 }
 
 
-function Buffer(arg) {
+function Buffer(arg, encoding) {
   // Common case.
   if (typeof arg === 'number') {
     // If less than zero, or NaN.
@@ -51,7 +51,11 @@ function Buffer(arg) {
 
   // Slightly less common case.
   if (typeof arg === 'string') {
-    return fromString(arg, arguments[1]);
+    encoding = encoding || '';
+    if (typeof encoding !== 'string' || encoding === '')
+      encoding = 'utf8';
+
+    return fromString(arg, encoding);
   }
 
   // Unusual.
@@ -103,9 +107,6 @@ function allocate(size) {
 
 
 function fromString(string, encoding) {
-  if (typeof encoding !== 'string' || encoding === '')
-    encoding = 'utf8';
-
   var length = byteLength(string, encoding);
   if (length >= (Buffer.poolSize >>> 1))
     return binding.createFromString(string, encoding);